[wp-trac] [WordPress Trac] #10889: filesystem's put_content() methods have inconsistent arguments -- causes .maintenance file to not be created

[WordPress Trac]

#10889: filesystem's put_content() methods have inconsistent arguments -- causes
.maintenance file to not be created
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |       Owner:  dd32       
     Type:  defect (bug)       |      Status:  new        
 Priority:  normal             |   Milestone:  3.0        
Component:  Filesystem         |     Version:  2.8.4      
 Severity:  normal             |    Keywords:  needs-patch
-------------------------------+--------------------------------------------

Comment(by dd32):

 Darn, forgot about this ticket.

 >  I'm not sure where the discussion is on the remainder of the patch.

 Denis is correct, the put_contents() function signature varies between
 classes, causing some upgrades to proceed without a .maintainence file.
 I'll take a look at it now and post a patch, You can decide if it should
 still wait for 3.0.

 Attached patch also fixes the "fix" that was used elsewhere, since
 put_contents() didnt do the chmod correctly, another call to chmod was
 made. At present, on the Direct transport, this means Chmod() will be
 called twice.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10889#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software