[wp-trac] [WordPress Trac] #10889: filesystem's put_content() methods have inconsistent arguments -- causes .maintenance file to not be created

[WordPress Trac]

#10889: filesystem's put_content() methods have inconsistent arguments -- causes
.maintenance file to not be created
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |       Owner:  dd32       
     Type:  defect (bug)       |      Status:  new        
 Priority:  normal             |   Milestone:  3.0        
Component:  Filesystem         |     Version:  2.8.4      
 Severity:  normal             |    Keywords:  needs-patch
-------------------------------+--------------------------------------------

Comment(by Denis-de-Bernardy):

 Replying to [comment:7 ryan]:
 I'm not sure where the discussion is on the remainder of the patch.
 Postponing to 3.0 for the remainder.

 Basically, the put_contents() method has inconsistent arguments. Depending
 on the FS used, it succeeds or fails. When it fails, it leaves a site that
 is getting upgraded without a .maintenance file.

 These two:

 {{{
 $wp_filesystem->put_contents($file, $maintenance_string, FS_CHMOD_FILE);
 $wp_filesystem->put_contents($maintenance_file, $maintenance_string,
 FS_CHMOD_FILE);
 }}}

 Should be changed accordingly. Or the put_contents() method should be
 fixed.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10889#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software