[wp-trac] [WordPress Trac] #11149: Images are still visible if trashed or if their parent post is unpublished

[WordPress Trac]

#11149: Images are still visible if trashed or if their parent post is unpublished
--------------------------+-------------------------------------------------
 Reporter:  aldenta       |       Owner:  aldenta    
     Type:  defect (bug)  |      Status:  assigned   
 Priority:  normal        |   Milestone:  2.9        
Component:  Media         |     Version:  2.9        
 Severity:  blocker       |    Keywords:  2nd-opinion
--------------------------+-------------------------------------------------
Changes (by nacin):

  * severity:  blocker => blocker


Comment:

 Replying to [comment:18 caesarsgrunt]:
 > Firstly, note that the problem here is basically that you can still see
 the image if you know the URL. But, this also applies to posts.

 No; trashed posts return a not found, same as if it was a draft, future,
 etc.

 > '''1.''' Check whether {{{post_status == 'inherit'}}} before showing the
 post thumbnail. Do this before '''2.9'''. This would leave us with
 Galleries and Thumbnails behaving in an optimal way, and images in posts
 behaving more or less as they currently do.

 This would work, except that images in posts would not behave as they
 currently do. When you delete an image, the HTML remains, but the file is
 gone.

 On the other hand, when you trash an image, the HTML and the file both
 remain, so it will still display. Big problem.

 This was extensively discussed in the dev meetup for today.
 https://irclogs.wordpress.org/chanlog.php?channel=wordpress-
 dev&day=2009-12-10&sort=asc. The decision the core devs decided on -- and,
 FWIW, most participants agreed to -- would be to disable Trash for Media,
 but keep the code in place and allow a plugin to turn it back on. Thus,
 Trash would function as if it was turned off, and fall back to the "Delete
 Permanently" links.

 There were many alternatives discussed, but nothing presented itself as a
 viable solution, especially with 2.9 so close.

 > '''2.''' Change the system for adding images to posts, so that it uses a
 shortcode rather than inserting direct html. Do this in '''3.0'''. This
 allows images to be somewhat dynamic

 It seems there was traction for an [image] shortcode for 3.0; I imagine
 that will be the basis of Trash for Media.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11149#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software