[wp-trac] [WordPress Trac] #11149: Images are still visible if trashed or if their parent post is unpublished
WordPress Trac
wp-trac at lists.automattic.com
Thu Dec 10 23:46:53 UTC 2009
#11149: Images are still visible if trashed or if their parent post is unpublished
--------------------------+-------------------------------------------------
Reporter: aldenta | Owner: aldenta
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 2.9
Component: Media | Version: 2.9
Severity: blocker | Keywords: 2nd-opinion
--------------------------+-------------------------------------------------
Comment(by caesarsgrunt):
Depends what you mean by "correct".[[BR]]
Firstly, note that the problem here is basically that you can still see
the image if you know the URL. But, this also applies to posts.[[BR]]
Secondly, note that the behaviour when you delete an image (pre 2.9) is
not "correct" either. The code for the image is still in the post, it's
just that the image file doesn't exist any more.
I '''strongly''' oppose the idea of disabling Trash for Media.
I propose taking the two actions described below :
'''1.''' Check whether {{{post_status == 'inherit'}}} before showing the
post thumbnail. Do this before '''2.9'''. This would leave us with
Galleries and Thumbnails behaving in an optimal way, and images in posts
behaving more or less as they currently do.
'''2.''' Change the system for adding images to posts, so that it uses a
shortcode rather than inserting direct html. Do this in '''3.0'''. This
allows images to be somewhat dynamic, with the ability for plugins to
alter their display etc - and enabling us to only show them if
{{{post_status == 'inherit'}}}.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/11149#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list