[wp-meta] [Making WordPress.org] #6792: Update Plugin Submission Page to check for zips

[Making WordPress.org]

#6792: Update Plugin Submission Page to check for zips
-------------------------------+---------------------
 Reporter:  Ipstenu            |       Owner:  (none)
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:
Component:  Plugin Directory   |  Resolution:
 Keywords:  reporter-feedback  |
-------------------------------+---------------------

Comment (by dd32):

 > That's what's weird, but we get broken zips on upload that won't
 properly unzip.

 Interesting.. I'm guessing these are archives that aren't actually ZIPs,
 but are another format that the linux `unzip` utility can decode - or
 potentially the ZIP is corrupted like you say, and the library we're using
 is unzipping it but throwing an error we're not catching (This looks
 likely).

 Looking at past plugin uploads, I can see a bunch of plugins are including
 some.. invalid filenames, such as banners and icons with non-ascii
 characters in the filenames, eg:
 {{{
 plugin-name/assets/icon-256#U00d7256.png:  mismatching "local" filename
 (plugin-name/assets/icon-256+�256.png),
          continuing with "central" filename version
 }}}

 I've found at least half a dozen plugin uploads since December that have
 that issue.

 I've been unable to find any .zips that fail to extract though, at least
 according to `unzip -t $zip`.

 Looking through the uploads, based on `file` utility.. everything seems to
 be ZIPs, but two are a newer version than the rest.. These seem like
 Zip64's
 {{{
 $ find . -name '*.zip' | xargs -I% file % | cut -d: -f2 | sort | uniq -c
     591  Zip archive data, at least v1.0 to extract
    1273  Zip archive data, at least v2.0 to extract
       2  Zip archive data, at least v4.5 to extract
 }}}

 I'll DM you examples of both to see if either of those are the issue.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/6792#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org