[wp-meta] [Making WordPress.org] #3791: Consider bumping pre-commit checker on plugins to PHP 7.1

Making WordPress.org noreply at wordpress.org
Wed Aug 21 17:52:55 UTC 2019

#3791: Consider bumping pre-commit checker on plugins to PHP 7.1
 Reporter:  Ipstenu           |       Owner:  (none)
     Type:  defect            |      Status:  new
 Priority:  high              |   Milestone:
Component:  Plugin Directory  |  Resolution:
 Keywords:  pending-systems   |

Comment (by xedin.unknown):

 > For the next person to run into this issue with their Composer
 dependencies, I thought of a temporary workaround:
 > {{{
 > "config": {
 >     "platform": {
 >         "php": "7.0"
 >     }
 > }
 > }}}

 This is not a work-around, because it prevents using code that requires
 any version that is higher (including higher patches, e.g. 7.0.1)

 IMO it is completely unreasonable to prevent commits if they fail to lint
 at **any** single PHP version, and the only acceptable solution is to make
 linting warn you, instead of outright rejecting the commit. If bumped up
 to 7.0, there definitely can be PHP 5.6 code which will start to behave
 unpredictably or outright break due to
 [https://www.php.net/manual/en/migration70.incompatible.php BC breaking
 changes]. Same will happen if bumped to 7.1. There is simply no one single
 linter target version that can satisfy the whole range of plugins that are
 acceptable in the SVN repository. The current restriction is stopping the
 community from using faster, safer, more robust and readable code, not to
 mention other libraries and standards, like the PSR-14. It is an obstacle
 for open-source software.

 Please remove the requirement for successful linting. We are an
 enterprize, and as such most of our plugins use at least PHP 7.1.

Ticket URL: <https://meta.trac.wordpress.org/ticket/3791#comment:21>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list