[wp-meta] [Making WordPress.org] #3791: Consider bumping pre-commit checker on plugins to PHP 7.1
Making WordPress.org
noreply at wordpress.org
Wed Aug 14 19:58:40 UTC 2019
#3791: Consider bumping pre-commit checker on plugins to PHP 7.1
------------------------------+---------------------
Reporter: Ipstenu | Owner: (none)
Type: defect | Status: new
Priority: high | Milestone:
Component: Plugin Directory | Resolution:
Keywords: pending-systems |
------------------------------+---------------------
Comment (by danielbachhuber):
For the next person to run into this issue with their Composer
dependencies, I thought of a temporary workaround:
{{{
"config": {
"platform": {
"php": "7.0"
}
}
}}}
If you haven't seen this before, this tells Composer to behave as though
it's updating your dependencies on a PHP 7.0 system. For us, the only
bundled change ended up being `Downgrading symfony/event-dispatcher
(v4.2.8 => v3.3.6)`, so it's a reasonable compromise. However, I did have
to also `"phpunit/phpunit": "^6 || ^7"`.
Lastly, I found https://github.com/JakubOnderka/PHP-Parallel-Lint to be a
neat tool for seeing which files failed to lint. If you're on a Mac
[https://joostvanveen.com/a-29/install-and-configure-multiple-php-
versions-on-mojave-with-homebrew here are instructions] on how to install
PHP 7.0 via Homebrew. Once you've done so, linting looks like this:
{{{
parallel-lint ./ -p /usr/local/Cellar/php at 7.0/7.0.33/bin/php
}}}
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/3791#comment:19>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list