[wp-meta] [Making WordPress.org] #2823: Improve IP Geolocation Results
Making WordPress.org
noreply at wordpress.org
Sat May 13 04:16:49 UTC 2017
#2823: Improve IP Geolocation Results
---------------------+-----------------------
Reporter: iandunn | Owner: iandunn
Type: defect | Status: accepted
Priority: normal | Milestone:
Component: API | Resolution:
Keywords: |
---------------------+-----------------------
Comment (by dd32):
> The first problem to solve is #2. I don't think we really need ipv6
support yet since the API should always use REMOTE_ADDR and the
WordPress.org API currently doesn't have any AAAA records.
The IP is not the REMOTE_ADDR in most cases - it's the WordPress user
client IP, not the server IP. There's some "anonymisation" stuff in there
([see maybe_anonymize_ip_address ()
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-
wp-community-events.php#L231]). The exception is when the client IP
provided is a private range, in which case it uses REMOTE_ADDR.
Would it be better if the client browser was making the request directly?
(and not proxied through WordPress) - the detect-location call would need
to be made on every request in that case, and not just on the first call /
when user searches for a location change.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2823#comment:13>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list