[wp-meta] [Making WordPress.org] #2882: Invalid values in Devhub_Handbooks::add_query_vars() for query_vars

[Making WordPress.org]

#2882: Invalid values in Devhub_Handbooks::add_query_vars() for query_vars
----------------------------+------------------
 Reporter:  grapplerulrich  |       Owner:
     Type:  defect          |      Status:  new
 Priority:  normal          |   Milestone:
Component:  Handbooks       |  Resolution:
 Keywords:  has-patch       |
----------------------------+------------------

Comment (by johnbillion):

 Replying to [comment:5 SergeyBiryukov]:
 > Right, but query vars as array element keys is the current code, not
 what the patch suggests. The patch removes the invalid filter usage for
 `empty_post_type_search`, same as [4294] did for `is_handbook_root`. Why
 is that incorrect?

 Yes you're correct, but the `Devhub_Handbooks::add_query_vars()` method
 still includes incorrect usage.

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2882#comment:6>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org