[wp-meta] [Making WordPress.org] #2882: Invalid values in Devhub_Handbooks::add_query_vars() for query_vars

[Making WordPress.org]

#2882: Invalid values in Devhub_Handbooks::add_query_vars() for query_vars
----------------------------+------------------
 Reporter:  grapplerulrich  |       Owner:
     Type:  defect          |      Status:  new
 Priority:  normal          |   Milestone:
Component:  Handbooks       |  Resolution:
 Keywords:  has-patch       |
----------------------------+------------------

Comment (by SergeyBiryukov):

 Replying to [comment:4 johnbillion]:
 > The query vars passed through the `query_vars` filter is an array with
 query vars as the array element values, not query vars as the array
 element keys.

 Right, but query vars as array element keys is the current code, not what
 the patch suggests. The patch removes the invalid filter usage for
 `empty_post_type_search`, same as [4294] did for `is_handbook_root`. Why
 is that incorrect?

--
Ticket URL: <https://meta.trac.wordpress.org/ticket/2882#comment:5>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org