[theme-reviewers] Theme Check update

[Sakin Shrestha]

Great. Will check in. Thanks

On Fri, Sep 12, 2014 at 7:23 AM, Justin Tadlock <justin at justintadlock.com>
wrote:

> On Thu, Sep 11, 2014 at 6:22 PM, Otto <otto at ottodestruct.com> wrote:
>>
>> IMO, the title should look like this, in the header.php, in all themes:
>>
>> <title><?php wp_title(whatever); ?></title>
>>
>> I honestly can't think of any good reason to do it any other way.
>> Certainly other ways exist, but they're all slower, make things more
>> difficult, and harder for people to understand.
>>
>> Why reinvent the wheel and make it octagonal?
>>
>
> There are certainly different schools of thought on how to develop themes.
>  Some folks even like octagonal wheels. This is something I can work around
> and am not going to worry too much about.
>
>
>> Actually, that check just sees if register_sidebar() is in the theme and
>> if widgets_init is not in the theme. If you are registering a sidebar, then
>> it should be happening in a function hooked to widgets_init, and not
>> anywhere else. Doesn't matter how it's handling HTML5 or what have you.
>>
>> So if the theme doesn't contain "widgets_init" anywhere but still
>> registers sidebars, that's a legitimate issue.
>>
>
> The issue is that the theme doesn't register widgets but the framework for
> the theme has a wrapper function for register_sidebar().  The call to
> register_sidebar() exists within the framework.  Here's a simplified
> version of the code:
>
> function prefix_register_sidebar( $args ) {
> /* set some defaults up. */
> register_sidebar( $args );
> }
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140912/2f2ae6c3/attachment.html>