[theme-reviewers] Theme Check update

Justin Tadlock justin at justintadlock.com
Fri Sep 12 01:38:19 UTC 2014

On Thu, Sep 11, 2014 at 6:22 PM, Otto <otto at ottodestruct.com> wrote:
> IMO, the title should look like this, in the header.php, in all themes:
> <title><?php wp_title(whatever); ?></title>
> I honestly can't think of any good reason to do it any other way.
> Certainly other ways exist, but they're all slower, make things more
> difficult, and harder for people to understand.
> Why reinvent the wheel and make it octagonal?

There are certainly different schools of thought on how to develop themes.
 Some folks even like octagonal wheels. This is something I can work around
and am not going to worry too much about.

> Actually, that check just sees if register_sidebar() is in the theme and
> if widgets_init is not in the theme. If you are registering a sidebar, then
> it should be happening in a function hooked to widgets_init, and not
> anywhere else. Doesn't matter how it's handling HTML5 or what have you.
> So if the theme doesn't contain "widgets_init" anywhere but still
> registers sidebars, that's a legitimate issue.

The issue is that the theme doesn't register widgets but the framework for
the theme has a wrapper function for register_sidebar().  The call to
register_sidebar() exists within the framework.  Here's a simplified
version of the code:

function prefix_register_sidebar( $args ) {
/* set some defaults up. */
register_sidebar( $args );
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140911/cd6dcd68/attachment.html>

More information about the theme-reviewers mailing list