[theme-reviewers] Theme Check update

Justin Tadlock justin at justintadlock.com
Thu Sep 11 22:19:43 UTC 2014


Great job on bringing things up to date.

Here are some required issues I ran into with currently-approved themes.
 Neither of these things are inherently incorrect, but they get flagged.

1) "The <title> tags can only contain a call to wp_title(). Use the
wp_title filter to modify the output."

This is caused by a custom function hooked to `wp_head` to output the
`<title>` tag.  This is should be easy enough to fix for theme check
though.  Here's the code that gets flagged:

printf( "<title>%s</title>\n", wp_title( ':', false ) );

2) "Sidebars need to be registered in a custom function hooked to the
widgets_init action. See: register_sidebar()."

This is caused by a wrapper function for `register_sidebar()` that handles
HTML5 defaults instead of the old-style lists.

On Thu, Sep 11, 2014 at 5:14 PM, Tammie Lister <karmatosed at gmail.com> wrote:

> Great stuff, thanks Otto and Fränk.
>
> Regards
> Tammie Lister
>
> On Thu, Sep 11, 2014 at 10:54 PM, Otto <otto at ottodestruct.com> wrote:
>
>> A new version of Theme Check has been sent to the trunk. I would
>> appreciate some testing and feedback, as there are a number of new tests
>> and changes and such.
>>
>> The new version is not final yet. The checks are not on WordPress.org
>> yet. They will likely change, so if something in there upsets you, be calm.
>> Don't blow your top just yet. :)
>>
>> The new updates are:
>>
>> * Updated deprecated function listings. These had not been updated in
>> some time, and Frank Klein at Automattic did a great job in getting these
>> up to date. Way more patience than I would have had. :)
>>
>> * Customizer check: All add_settings must use sanitization callbacks, for
>> security. This one is kind of a no-brainer, really. Any input should be
>> properly sanitized.
>>
>> * Plugin territory checks: Themes must not register post types or
>> taxonomies or add shortcodes for post content.
>>
>> * Widgets: Calls to register_sidebar must be called from the widgets_init
>> action hook.
>>
>> * Title: <title> tags must exist and not have anything in them other than
>> a call to wp_title().
>>
>> * CDN: Checks for use of a few common CDNs. I'm still on the fence on
>> this one, might make it a warning only rather than a failure.
>>
>> The development version of Theme Check can be acquired here:
>> http://downloads.wordpress.org/plugin/theme-check.zip
>>
>> Or here:
>> http://plugins.svn.wordpress.org/theme-check/trunk
>>
>>
>> -Otto
>>
>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140911/36d73e4d/attachment-0001.html>


More information about the theme-reviewers mailing list