<div dir="ltr"><div>Great job on bringing things up to date.</div><div><br></div><div>Here are some required issues I ran into with currently-approved themes. Neither of these things are inherently incorrect, but they get flagged.</div><div><br></div><div>1) "The <title> tags can only contain a call to wp_title(). Use the wp_title filter to modify the output."</div><div><br></div><div>This is caused by a custom function hooked to `wp_head` to output the `<title>` tag. This is should be easy enough to fix for theme check though. Here's the code that gets flagged:</div><div><br></div><div><span class="" style="white-space:pre"> </span>printf( "<title>%s</title>\n", wp_title( ':', false ) );</div><div><br></div><div>2) "Sidebars need to be registered in a custom function hooked to the widgets_init action. See: register_sidebar()."</div><div><br></div><div>This is caused by a wrapper function for `register_sidebar()` that handles HTML5 defaults instead of the old-style lists. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 11, 2014 at 5:14 PM, Tammie Lister <span dir="ltr"><<a href="mailto:karmatosed@gmail.com" target="_blank">karmatosed@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Great stuff, thanks Otto and Fränk.<div><br></div><div>Regards</div><span class="HOEnZb"><font color="#888888"><div>Tammie Lister</div></font></span></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Thu, Sep 11, 2014 at 10:54 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr">A new version of Theme Check has been sent to the trunk. I would appreciate some testing and feedback, as there are a number of new tests and changes and such.<div><br></div><div>The new version is not final yet. The checks are not on WordPress.org yet. They will likely change, so if something in there upsets you, be calm. Don't blow your top just yet. :)</div><div><br></div><div>The new updates are:</div><div><br></div><div><div>* Updated deprecated function listings. These had not been updated in some time, and Frank Klein at Automattic did a great job in getting these up to date. Way more patience than I would have had. :)</div><div><br></div><div>* Customizer check: All add_settings must use sanitization callbacks, for security. This one is kind of a no-brainer, really. Any input should be properly sanitized.</div><div><br></div><div>* Plugin territory checks: Themes must not register post types or taxonomies or add shortcodes for post content. </div><div><br></div><div>* Widgets: Calls to register_sidebar must be called from the widgets_init action hook. </div><div><br></div><div>* Title: <title> tags must exist and not have anything in them other than a call to wp_title().</div><div><br></div><div>* CDN: Checks for use of a few common CDNs. I'm still on the fence on this one, might make it a warning only rather than a failure.</div></div><div><br></div><div>The development version of Theme Check can be acquired here:</div><div><a href="http://downloads.wordpress.org/plugin/theme-check.zip" target="_blank">http://downloads.wordpress.org/plugin/theme-check.zip</a></div><div><br></div><div>Or here:</div><div><a href="http://plugins.svn.wordpress.org/theme-check/trunk" target="_blank">http://plugins.svn.wordpress.org/theme-check/trunk</a><span><font color="#888888"><br></font></span></div><span><font color="#888888"><div><br></div><div><br></div><div><div>-Otto</div><div><br></div><div><br></div><div><br></div>
</div></font></span></div>
<br></div></div><span class="">_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></span></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>