[theme-reviewers] Theme Unit Tests on GitHub?

Fri Oct 17 01:18:20 UTC 2014

Tammie will take a lead on this next week.

On Thursday, October 16, 2014, Gary Jones <gary at gamajo.com> wrote:

> I understand Tammie. I disagree that's it's complicated, but I do agree
> that's it's an extra level of administration for those not yet comfortable
> with Grunt or the command line. My previous response was addressing the
> specific concern that adding it meant any change for users regarding
> multiple files etc. Getting it on the repo itself is the main task here.
>
> Can someone with WPTRT admin access on Github please claim ownership on
> getting the repo setup, at some point convenient to them?
>
> ----
> Gary Jones
> Web Developer,  Gamajo Tech
> On 16 Oct 2014 22:38, "Tammie Lister" <karmatosed at gmail.com
> <javascript:_e(%7B%7D,'cvml','karmatosed at gmail.com');>> wrote:
>
>>  Gary,
>>
>> My concern is it's adding a level of contribution and administration
>> complication for the first steps we could do without. Never say never, but
>> lets leave it from the start.
>>
>> Thanks
>> Tammie
>>
>> On 16/10/2014 22:36, Gary Jones wrote:
>>
>> And with my proposal, it would.
>> dist/theme-unit-tests.xml would be the same as the file now, and
>> dist/theme-unit-tests-wpcom.xml for those who need to test the extra WP.com
>> bits Lance mentioned. All from the same source.
>>
>> ----
>> Gary Jones
>> Web Developer,  Gamajo Tech
>> On 16 Oct 2014 21:36, "Edward Caissie" <edward.caissie at gmail.com
>> <javascript:_e(%7B%7D,'cvml','edward.caissie at gmail.com');>> wrote:
>>
>>> The Theme Unit Test (TUT) data needs to stay as easy to acquire as it is
>>> prior to being moved from its current repository. Simply put, it should
>>> remain as a single file download for theme designers ready to be used
>>> without any additional work aside from importing it into a WordPress
>>> installation.
>>>
>>>
>>>
>>> Edward Caissie
>>> aka Cais.
>>>
>>> On Thu, Oct 16, 2014 at 3:27 PM, Tammie Lister <karmatosed at gmail.com
>>> <javascript:_e(%7B%7D,'cvml','karmatosed at gmail.com');>> wrote:
>>>
>>>>  Hi
>>>>
>>>> My opinion would be no Grunt because we're adding complexity - lets get
>>>> things working without things extra first.
>>>>
>>>> Thanks
>>>> Tammie
>>>>
>>>>
>>>> On 16/10/2014 20:04, Gary Jones wrote:
>>>>
>>>> Thanks Lance.
>>>>
>>>> Any opinions on a little Grunt file for the purpose of easily and
>>>> consistently removing the WP.com bits? (and whatever other tasks on the
>>>> file might need doing between source and distributable file).
>>>>
>>>> Note that this isn't introducing any NodeJS dependency for *using* the
>>>> XML file, but it reduces the task of searching and replacing several regex
>>>> strings down to a single command line call.
>>>>
>>>> I'd envisage a structure of something like:
>>>>
>>>> * src/theme-unit-tests.xml
>>>> * dist/theme-unit-tests.xml
>>>> * dist/theme-unit-tests-wpcom.xml
>>>> * gruntfile.js
>>>> * package.json
>>>> * README.md
>>>>
>>>> The dist files would be updated by Grunt from the src file, and adapted
>>>> by Grunt for WP.com and everyone else accordingly.
>>>> ----
>>>> Gary Jones
>>>> Web Developer,  Gamajo Tech
>>>> On 16 Oct 2014 18:45, "Emil Uzelac" <emil at uzelac.me
>>>> <javascript:_e(%7B%7D,'cvml','emil at uzelac.me');>> wrote:
>>>>
>>>>> Thanks kind lady :)
>>>>>
>>>>> On Thursday, October 16, 2014, Tammie Lister <karmatosed at gmail.com
>>>>> <javascript:_e(%7B%7D,'cvml','karmatosed at gmail.com');>> wrote:
>>>>>
>>>>>>  Sure, I'll pop it over next week.
>>>>>>
>>>>>> Thanks
>>>>>> Tammie
>>>>>>
>>>>>> On 16/10/2014 18:42, Emil Uzelac wrote:
>>>>>>
>>>>>> Tammie would you like to start?
>>>>>>
>>>>>> On Thursday, October 16, 2014, Tammie Lister <karmatosed at gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>>  Hi
>>>>>>>
>>>>>>> I'm down with putting it on GH but we do need to make sure we have a
>>>>>>> process and particularly how it's prepared.
>>>>>>>
>>>>>>> Thanks
>>>>>>> Tammie
>>>>>>>
>>>>>>> On 16/10/2014 18:29, Edward Caissie wrote:
>>>>>>>
>>>>>>> Fine by me ...
>>>>>>>
>>>>>>>
>>>>>>> Edward Caissie
>>>>>>> aka Cais.
>>>>>>>
>>>>>>> On Thu, Oct 16, 2014 at 1:23 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>>>>>>
>>>>>>>> Awesome and thanks. So guys should we push over to TRT GH or?
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thursday, October 16, 2014, Lance Willett <nanobar at gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Here's the checklist for preparing a new XML file, next time you
>>>>>>>>> need to do it.
>>>>>>>>>
>>>>>>>>> Often when I get the new XML file from
>>>>>>>>> http://wpthemetestdata.wordpress.com/ it needs a bit of massaging
>>>>>>>>> before commit to our pub repo.
>>>>>>>>>
>>>>>>>>> Here’s the process
>>>>>>>>>
>>>>>>>>> 1. WPTRT admins make changes to the test site on WP.com.
>>>>>>>>> 2. Go to http://wpthemetestdata.wordpress.com/ and export the
>>>>>>>>> full XML
>>>>>>>>> file, and open it locally in a text editor.
>>>>>>>>> 3. Clean it up.
>>>>>>>>> 4. Diff it with the previous version to be sure of no weird
>>>>>>>>> changes or
>>>>>>>>> additions, other than the expected ones.
>>>>>>>>> 5. Push to GitHub.
>>>>>>>>> 6. Go to http://codex.wordpress.org/Theme_Unit_Test, edit the
>>>>>>>>> page,
>>>>>>>>> change the UTC timestamp to “now” to show the most current update
>>>>>>>>> timestamp. **You can stop doing this probably since GitHub will
>>>>>>>>> have a
>>>>>>>>> history going forward.**
>>>>>>>>>
>>>>>>>>> Notes for the XML clean up, step 3.
>>>>>>>>>
>>>>>>>>> Remove the following metadata elements that are specific to WP.com.
>>>>>>>>>
>>>>>>>>> superawesome
>>>>>>>>> _edit_last
>>>>>>>>> email_notification
>>>>>>>>> _searchme
>>>>>>>>> jabber_published
>>>>>>>>> geo_public
>>>>>>>>> _elasticsearch_indexed_on
>>>>>>>>>
>>>>>>>>> I look for these patterns using a text editor like TextMate or
>>>>>>>>> Sublime
>>>>>>>>> Text, with regex search turned on:
>>>>>>>>>
>>>>>>>>> 1. https://gist.github.com/lancewillett/a7c849026e2e403399a0
>>>>>>>>> 2. https://gist.github.com/lancewillett/127085c444ec6ff398d1
>>>>>>>>>
>>>>>>>>> Then search/replace with an empty string to remove from the XML
>>>>>>>>> file.
>>>>>>>>>
>>>>>>>>> It's not end of the world if they make it into the Unit Test XML
>>>>>>>>> file,
>>>>>>>>> but it's just clutter.
>>>>>>>>>
>>>>>>>>> – Lance
>>>>>>>>>
>>>>>>>>> On Thu, Oct 16, 2014 at 11:15 AM, Lance Willett <nanobar at gmail.com>
>>>>>>>>> wrote:
>>>>>>>>> > The history of the file changes is public, it's part of our
>>>>>>>>> WP.com
>>>>>>>>> > public themes SVN repo.
>>>>>>>>> >
>>>>>>>>> > You can see the history by doing something like:
>>>>>>>>> > svn log
>>>>>>>>> https://wpcom-themes.svn.automattic.com/demo/theme-unit-test-data.xml
>>>>>>>>> >
>>>>>>>>> > I'm totally happy for the file to move to GitHub. If WPTRT has an
>>>>>>>>> > account and you'd like to maintain it going forward—please just
>>>>>>>>> grab
>>>>>>>>> > the latest copy and start from there; I don't need to do anything
>>>>>>>>> > further.
>>>>>>>>> >
>>>>>>>>> > Then edit the Codex page at
>>>>>>>>> http://codex.wordpress.org/Theme_Unit_Test
>>>>>>>>> > to point to the GitHub repo instead of the SVN repo.
>>>>>>>>> >
>>>>>>>>> > Done. :)
>>>>>>>>> >
>>>>>>>>> > – Lance
>>>>>>>>> _______________________________________________
>>>>>>>>> theme-reviewers mailing list
>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> theme-reviewers mailing list
>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> theme-reviewers mailing listtheme-reviewers at lists.wordpress.orghttp://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Thanks
>>>>>>> Tammie Lister
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing listtheme-reviewers at lists.wordpress.orghttp://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks
>>>>>> Tammie Lister
>>>>>>
>>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> <javascript:_e(%7B%7D,'cvml','theme-reviewers at lists.wordpress.org');>
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing listtheme-reviewers at lists.wordpress.org <javascript:_e(%7B%7D,'cvml','theme-reviewers at lists.wordpress.org');>http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>> --
>>>> Thanks
>>>> Tammie Lister
>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> <javascript:_e(%7B%7D,'cvml','theme-reviewers at lists.wordpress.org');>
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> <javascript:_e(%7B%7D,'cvml','theme-reviewers at lists.wordpress.org');>
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing listtheme-reviewers at lists.wordpress.org <javascript:_e(%7B%7D,'cvml','theme-reviewers at lists.wordpress.org');>http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>> --
>> Thanks
>> Tammie Lister
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> <javascript:_e(%7B%7D,'cvml','theme-reviewers at lists.wordpress.org');>
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20141016/6b888f8a/attachment-0001.html>