[theme-reviewers] Google fonts - proper way to integrate in a theme
justin at justintadlock.com
Fri Oct 3 22:59:42 UTC 2014
The reason I say it's not something we should be concerned with is because,
for the moment, our focus needs to simply be on making sure themes actually
work correctly. With all the work we've done over the years, I still don't
feel like we're at a point where we're getting the kind of quality code
that we should be getting from theme authors. As I look through themes
today, even after they've been reviewed and updated and reviewed and
updated, there's still quite a bit of code that really should be better.
I consider recommending not to use `@import` right there in line with the
Theme Unit Tests. It's great if theme authors do it, but we've got too
much on our plates as reviewers right now.
We still have problems with basic stuff like getting people to license
their themes correctly, using the right template tags, and learning the
difference between "home" and "front page". To top all of that off, themes
are only getting more complicated.
I think discussions on the performance of doing something one way vs.
another way are great, but I don't think we're there yet in terms of making
this sort of thing a requirement under the guidelines.
On Fri, Oct 3, 2014 at 5:35 PM, Tammie Lister <karmatosed at gmail.com> wrote:
> Whilst I'm not advocating we do it right now, it's food for thought.
> Personally, I don't think it's far reaching. Not when we want to encourage
> best practices and that is one. It a little depends on context, which a
> guideline would outline.
> Perhaps we're a little early, perhaps it's just a good thing we are having
> this discussion as it puts out there the fact that import is not the right
> path. I personally, would say never but I know that there are with anything
> a range of opinions on that.
> Outside of WPTRT it's always my recommendation you avoid imports in
> php/html files. The exception to that rule I'd suggest would be Sass or
> other pre-processing inclusions. Again, my own opinion.
> Tammie Lister
> On Fri, Oct 3, 2014 at 11:00 PM, Justin Tadlock <justin at justintadlock.com>
>> Stopping the use of @import is probably a little far-reaching to be
>> honest. I don't think it's something we need to be actively looking for.
>> At best, I think we should go as far a making it "recommended" to not use
>> On Fri, Oct 3, 2014 at 4:43 PM, Tammie Lister <karmatosed at gmail.com>
>>> Maybe an opportunity to include this in the guideline. We need to stop
>>> the use of imports :)
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the theme-reviewers