[theme-reviewers] Google fonts - proper way to integrate in a theme

[Christine Rondeau]

Great thank you.

I started reviewing this theme here -
https://themes.trac.wordpress.org/ticket/20454
but I must have sat on it too long and it got assigned to someone else.

I added my findings to the ticket. Hopefully it will help with the rest of
the review.

I'll pick another, but maybe after a bike ride... I think that the ticket
re-assigning by Emil was his way to say... get out of here, it's friday...

Cheers everyone

Christine Rondeau
Bluelime Media
www.bluelimemedia.com
twitter: @bluelimemedia
skype: bluelimemedia








On Fri, Oct 3, 2014 at 2:18 PM, Emil Uzelac <emil at uzelac.me> wrote:

> For that reason I like to include all styles via wp_enqueue :)
>
> On Fri, Oct 3, 2014 at 4:16 PM, Zack Tollman <tollmanz at gmail.com> wrote:
>
>> FWIW, `@import` is particularly horrendous for performance when loading
>> fonts. `@import` CSS is blocked by linked CSS. That combined with the fact
>> that most browsers try to hold up the initial paint until the fonts are
>> ready can cause really bad performance.
>>
>> Steve Souders does a good job talking about the performance impact of
>> `@import`, but not in the font loading context:
>> http://www.stevesouders.com/blog/2009/04/09/dont-use-import/
>>
>> On Fri, Oct 3, 2014 at 2:09 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>
>>> My favorite is
>>> http://themeshaper.com/2014/08/13/how-to-add-google-fonts-to-wordpress-themes/
>>> as well :) Good control over the SSL and translations.
>>>
>>> On Fri, Oct 3, 2014 at 4:06 PM, Justin Tadlock <justin at justintadlock.com
>>> > wrote:
>>>
>>>> It's fine to @import stylesheets, regardless of whether it's a font
>>>> stylesheet.
>>>>
>>>> On Fri, Oct 3, 2014 at 4:01 PM, Christine Rondeau <
>>>> christine at bluelimemedia.com> wrote:
>>>>
>>>>> Hi there,
>>>>>
>>>>> Just reviewing a theme here and google fonts are used, but these are
>>>>> simply inserted at the top of the css, using  @import.
>>>>>
>>>>> I don’t think I’ve ever seen that before and think that enqueuing is
>>>>> best practice, but is there a link to this in the guideline somewhere? Or
>>>>> maybe I’m just wrong and this is perfectly acceptable
>>>>> Christine
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20141003/74a4595c/attachment.html>