<div dir="ltr">Great thank you.<div><br></div><div>I started reviewing this theme here - <a href="https://themes.trac.wordpress.org/ticket/20454">https://themes.trac.wordpress.org/ticket/20454</a></div><div>but I must have sat on it too long and it got assigned to someone else. </div><div><br></div><div>I added my findings to the ticket. Hopefully it will help with the rest of the review. </div><div><br></div><div>I'll pick another, but maybe after a bike ride... I think that the ticket re-assigning by Emil was his way to say... get out of here, it's friday... </div><div><br></div><div>Cheers everyone</div></div><div class="gmail_extra"><br clear="all"><div><i><b></b></i>Christine Rondeau<br>Bluelime Media<br><a href="http://www.bluelimemedia.com" target="_blank">www.bluelimemedia.com</a><br>twitter: @bluelimemedia<div>skype: bluelimemedia<br><br><br><b><br></b><b><span style="font-size:9.0pt;font-family:"Verdana","sans-serif";color:red"></span></b><b><span style="font-size:9.0pt;font-family:"Verdana","sans-serif";color:black"><br></span></b><br><br><i></i><br></div></div>
<br><div class="gmail_quote">On Fri, Oct 3, 2014 at 2:18 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">For that reason I like to include all styles via wp_enqueue :)</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 3, 2014 at 4:16 PM, Zack Tollman <span dir="ltr"><<a href="mailto:tollmanz@gmail.com" target="_blank">tollmanz@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">FWIW, `@import` is particularly horrendous for performance when loading fonts. `@import` CSS is blocked by linked CSS. That combined with the fact that most browsers try to hold up the initial paint until the fonts are ready can cause really bad performance.<div><br></div><div>Steve Souders does a good job talking about the performance impact of `@import`, but not in the font loading context: <a href="http://www.stevesouders.com/blog/2009/04/09/dont-use-import/" target="_blank">http://www.stevesouders.com/blog/2009/04/09/dont-use-import/</a></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 3, 2014 at 2:09 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">My favorite is <a href="http://themeshaper.com/2014/08/13/how-to-add-google-fonts-to-wordpress-themes/" target="_blank">http://themeshaper.com/2014/08/13/how-to-add-google-fonts-to-wordpress-themes/</a> as well :) Good control over the SSL and translations. </div></div><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Oct 3, 2014 at 4:06 PM, Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span> wrote:<br></span><div><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It's fine to @import stylesheets, regardless of whether it's a font stylesheet. </div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Fri, Oct 3, 2014 at 4:01 PM, Christine Rondeau <span dir="ltr"><<a href="mailto:christine@bluelimemedia.com" target="_blank">christine@bluelimemedia.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr">
<p>Hi there, </p><p>Just reviewing a theme here and google fonts are used, but these are simply inserted at the top of the css, using @import. </p><p>I don’t think I’ve ever seen that before and think that enqueuing is best practice, but is there a link to this in the guideline somewhere? Or maybe I’m just wrong and this is perfectly acceptable</p><span><font color="#888888"><div><i><b></b></i>Christine <div><br><b><br></b><b><span style="font-size:9pt;font-family:Verdana,sans-serif;color:red"></span></b><b><span style="font-size:9pt;font-family:Verdana,sans-serif;color:black"><br></span></b><br><br><i></i><br></div></div>
</font></span></div>
<br></div></div><span>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></span></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div></div></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>