[theme-reviewers] Can Options Framework be included with the theme?

[Bass Jobsen]

Hello,

Please also see: https://themes.trac.wordpress.org/ticket/15869#comment:19
On the first sight i also thought it as impossible to make it optional.
Then read: https://themes.trac.wordpress.org/ticket/15869#comment:21
Finally i made it optional, i think that's the right chose now.

Regards,

Bass


2014-03-05 11:53 GMT+01:00 Thomas Ireland <info at designchapter.com>:

> Sorry to bring this up again
>
> https://themes.trac.wordpress.org/ticket/17038 - Theme is using
> optiontree plugin which unlike options framework does not have a framework,
> therefore it has been bundled with the theme. I think I have correctly
> advised magictheme that this plugin territory (and this is affirmed by
> Chip's comment on https://themes.trac.wordpress.org/ticket/16895) and
> should consider using options framework instead.
>
> However when I search I can see that theme Hueman
> https://themes.trac.wordpress.org/ticket/16616 uses option tree in a
> similar fashion and has been approved multiple times with it bundled.
>
> I just want to know that going forward:
>  - I should still take the plugin territory stance (and advice use of
> Options-Framework framework
>  - or make the decision on a per theme basis?
>
> Thanks
>
>
> On Sat, Feb 22, 2014 at 3:05 PM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> No worries; just a general reminder. This specific issue is probably
>> worth bringing to the mail-list post-resolution, as it has come up a few
>> times now. :)
>>
>>
>> On Sat, Feb 22, 2014 at 10:02 AM, Rohit Tripathi <rohitink at live.com>wrote:
>>
>>> Yes, chip. But, I do understand that. But, Even I wasn't 100% sure. It
>>> was tried explaining to the author, but he said a new rule is there against
>>> it. Hence, I was all skeptical again.
>>>
>>> Sorry for bringing it to the mailing list. Pardon me.
>>>
>>> :)
>>>
>>> ------------------------------
>>> Date: Sat, 22 Feb 2014 09:59:22 -0500
>>>
>>> From: chip at chipbennett.net
>>> To: theme-reviewers at lists.wordpress.org
>>> Subject: Re: [theme-reviewers] Can Options Framework be included with
>>> the theme?
>>>
>>> Note: this is probably something that should have been attempted to be
>>> resolved in-ticket before bringing to the list.
>>>
>>>
>>> On Sat, Feb 22, 2014 at 9:58 AM, Rohit Tripathi <rohitink at live.com>wrote:
>>>
>>> Yes, indeed. I have been using the Framework version, since always and
>>> hence wasn't never asked to change it by any reviewer.
>>>
>>> Here is a ticket no. https://themes.trac.wordpress.org/ticket/16871
>>>
>>> I think, catchthemes is a new reviewer and not familiar with it. I will
>>> refer him to read this mail.
>>>
>>> :)
>>>
>>>
>>> ------------------------------
>>> Date: Sat, 22 Feb 2014 09:56:18 -0500
>>> From: chip at chipbennett.net
>>> To: theme-reviewers at lists.wordpress.org
>>> Subject: Re: [theme-reviewers] Can Options Framework be included with
>>> the theme?
>>>
>>>
>>> Options Framework can be confusing, because it comes in two forms: a
>>> stand-alone Plugin, and a framework intended to be integrated into a Theme
>>> or Plugin. Themes should use the framework version.
>>>
>>>
>>> On Sat, Feb 22, 2014 at 9:54 AM, Srikanth Koneru <tskk79 at gmail.com>wrote:
>>>
>>> Otions framework and many other frameworks are included in many themes
>>> for a long time, your reviewer may have misconstrued the plugins should not
>>> be bundled rule.
>>>
>>>
>>>  On Sat, Feb 22, 2014 at 8:17 PM, Rohit Tripathi <rohitink at live.com>wrote:
>>>
>>>  Hello All,
>>>
>>> I have been beliveing that options framework is allowed in themes. And
>>> it has been included in most of my themes. But, in one of the reviews, the
>>> Author Asked me to remove the Options Framework, and make the user install
>>> it separately as a plugin.
>>>
>>> Technically, my theme doesn't bundle the OF plugin. Its theme options
>>> panel is built using it with slight modification.
>>>
>>> Is there are rule like this, where I can not include OF in the theme? I
>>> know that bundling external plugins, is not allowed. But, I think its
>>> different about Options Framework.
>>>
>>> Regards,
>>> Rohit Tripathi
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>>
>>> _______________________________________________ theme-reviewers mailing
>>> list theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>>
>>> _______________________________________________ theme-reviewers mailing
>>> list theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140305/83e797e5/attachment.html>