[theme-reviewers] Is Blog.php is allowed in theme?

[Philip M. Hofer (Frumph)]

It doesn’t give incorrect results if the page set has a blog.php template; it works perfectly and as wanted; at that time it doesn’t execute the show on home events.
Really don’t like the idea of “failed to set it up completely”;  plethora amount of users do not see that as how it is either – there’s no warning or contextual help to say otherwise anywhere.
Please take note of that.
From: Otto 
Sent: Saturday, July 05, 2014 10:26 AM
To: Discussion list for WordPress theme reviewers. 
Subject: Re: [theme-reviewers] Is Blog.php is allowed in theme?

On Sat, Jul 5, 2014 at 12:21 PM, Philip M. Hofer (Frumph) <philip at frumph.net> wrote:

  Yes, it does.  

  Try it.  

  Coincidently, don’t set a ‘front page displays’ ... it is not required to do so, nor necessary.   I think that’s where your thought process is failing, people who want the landing page to not change; will not set the front page to be some “other” page.  They want the events that are triggered to be on the landing page to be ON the landing page.

  If the core dev’s wanted it to be required to make the front-page be set if you set the posts page then they would have made it so.


Yes, but that's a setting issue. If you don't set a "front-page displays" setting, then the front-page displays the posts, and is_front_page will return false because you failed to set it up completely. See public function is_front_page() in wp-includes/query.php where it explicitly checks for both the setting to be a "page" and for it to be a named page that exists.

You have to set both settings. If you only set one setting, then the settings are incomplete and you will get wonky results. You can consider this a core bug if you like, but for the settings there to be correct and the hierarchy to act correctly, both settings must be set to an actual page. Setting only one of them will give you incorrect results.


-Otto



--------------------------------------------------------------------------------
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140705/4291c59e/attachment.html>