[theme-reviewers] theme-reviewers Digest, Vol 45, Issue 12

[Ramiro C.]

Hello i am reviewing freeside and i need help with sanitization, validation this theme run script tags from posts meta tags, in editing posts and adding a text field, the thing is how would i trace from the galhimathias of code which validation sanitization is required for each field (should i suggest a solution or its enough to say validate sanitize data input on file http://themes.svn.wordpress.org/freeside/2.2/chimera/theme/meta_boxes.php)
2 if there is a function exist check its because you must use such a checked function right?
3 dynamic sidebar and register sidebar comes togethe?r its a 1on1 if theres a call to register .. should be one call in code to dynamic?
4 Multiple doctypes are not allowed right, just choose one and stay with that
5 html5 theme support was called but doctype mismatch, i am guessing but it will fail to validate no?
6 on every created function should be established a prefix like function themename-idosomething () {}?

Thanks





Enviado desde Samsung tablet

-------- Mensaje original --------
De: theme-reviewers-request at lists.wordpress.org 
Fecha: 05/02/2014  12:24  (GMT-03:00) 
A: theme-reviewers at lists.wordpress.org 
Asunto: theme-reviewers Digest, Vol 45, Issue 12 
 
On Wed, Feb 5, 2014 at 8:28 AM, Rohit Tripathi <rohitink at live.com> wrote:
What if the theme slug is the name of theme shop, and common to all other themes from the author?



That doesn't make any sense. The theme slug is unique and based on the name of the theme.

Just to pick two at random from the queue:

https://themes.trac.wordpress.org/ticket/16410 - Theme slug = "isis".
https://themes.trac.wordpress.org/ticket/16419 - Theme slug = "minimagazine".

Slugs cannot be "common", they are unique to the theme.

-Otto
 
Okay. Sorry, I confused Theme Slug with Function prefixes. Grrrr......

Sorry, for all the confusion.

From: otto at ottodestruct.com
Date: Wed, 5 Feb 2014 08:32:59 -0600
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] Can Text Domain be name of the Theme shop?

On Wed, Feb 5, 2014 at 8:28 AM, Rohit Tripathi <rohitink at live.com> wrote:
What if the theme slug is the name of theme shop, and common to all other themes from the author?



That doesn't make any sense. The theme slug is unique and based on the name of the theme.

Just to pick two at random from the queue:

https://themes.trac.wordpress.org/ticket/16410 - Theme slug = "isis".
https://themes.trac.wordpress.org/ticket/16419 - Theme slug = "minimagazine".

Slugs cannot be "common", they are unique to the theme.

-Otto
 

_______________________________________________ theme-reviewers mailing list theme-reviewers at lists.wordpress.org http://lists.wordpress.org/mailman/listinfo/theme-reviewers
Is it okay to have option for Ads ?
Is it okay to remove wp_generator  meta tag?
Maybe, depends how it is done. 
No.
On 5 Feb 2014 16:04, "bravo keyl" <bravokeyl at gmail.com> wrote:
Is it okay to have option for Ads ?
Is it okay to remove wp_generator  meta tag?

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

I'm pretty sure it's not okay to remove the wp_generator tag. 

On Wednesday, 5 February 2014, bravo keyl <bravokeyl at gmail.com> wrote:
Is it okay to have option for Ads ?
Is it okay to remove wp_generator  meta tag?


-- 
- Sent from iPad
I would say a Widget Area is appropriate for Ads. That way, the user does not lose the Ad content when switching Themes.

Removing the generator meta tag is unrelated to presentation of user content, and thus Plugin territory.


On Wed, Feb 5, 2014 at 10:04 AM, bravo keyl <bravokeyl at gmail.com> wrote:
Is it okay to have option for Ads ?
Is it okay to remove wp_generator  meta tag?

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers


As user  loses the ad code when switching themes ...so it's not okay..

I take no for that option.


On Wed, Feb 5, 2014 at 8:51 PM, Chip Bennett <chip at chipbennett.net> wrote:
I would say a Widget Area is appropriate for Ads. That way, the user does not lose the Ad content when switching Themes.

Removing the generator meta tag is unrelated to presentation of user content, and thus Plugin territory.


On Wed, Feb 5, 2014 at 10:04 AM, bravo keyl <bravokeyl at gmail.com> wrote:
Is it okay to have option for Ads ?
Is it okay to remove wp_generator  meta tag?

_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers



_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140205/f92e727d/attachment.html>