[theme-reviewers] PHP namespace

[Ryan Van Etten]

My *reasons* to submit action <https://github.com/ryanve/action> to WPORG
are to:

   1. prevent incorrect dashboard updates from a conflicting WPORG theme
   2. prevent overall name confusion
   3. enable updates via Dashboard -> Updates
   4. enable installs via Appearance -> Themes

Is there an official way to solve #1 and #2 from outside WPORG? #3 and #4
are pure convenience. For me it would mean maintaining SVN in addition to
Github.

*Thanks* all for the solid feedback. I tried to clarify all points in
ticket #12206 <http://themes.trac.wordpress.org/ticket/12206#comment:2>.
Note there is a newer
submission<http://themes.trac.wordpress.org/query?keywords=~theme-action>.
Itemized
commits <https://github.com/ryanve/action/commits/master> are viewable by
range like 1.1.7...1.2.11<https://github.com/ryanve/action/compare/1.1.7...1.2.11>
and
relevant issues are here <https://github.com/ryanve/action/issues>.


@ryanve <http://twitter.com/ryanve> | 646-853-4941 |
ryanve.com<http://ryanvanetten.com/>




On Wed, May 22, 2013 at 5:21 PM, Andrew Nacin <wp at andrewnacin.com> wrote:

> On Wed, May 22, 2013 at 4:02 PM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> The issue of passing anonymous functions to hooks is certainly valid.
>> Hooks must reference a valid callback, so that they can be overridden.
>>
>> Another major concern is that the Theme *requires* a PHP version higher
>> than that required by WordPress core.
>>
>
> If a theme cannot safely activate on the minimum version of PHP required
> by WordPress, then it has no place in the directory.
>
> In core, I don't think we "sandbox" themes the way we do plugins. If this
> triggers fatal errors in 5.2, that's a no-no. The only alternative would be
> for it to switch back to the previous theme if it cannot run in 5.2. It
> looks like this theme does do this:
> http://themes.svn.wordpress.org/action/1.1.7/functions.php
>
> The big problem with using PHP closures in a theme is that a child theme
> (or a plugin) cannot remove_action() or that add_action( $hook, function()
> { ... } ) call. (Same goes for remove_filter() and add_filter().) Even when
> core moves to PHP 5.3, we will not use closures in this way. They just
> aren't compatible with our simplistic hook API.
>
> I don't think that is a reason to reject this theme. But I'm not sure such
> a developer-oriented theme has much of a place in the generic user-oriented
> themes directory. I would be interested to see if ryanve (the developer)
> ultimately agrees it should stay on GitHub.
>
> Nacin
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130524/f4648165/attachment.html>