<div dir="ltr"><div>My <b>reasons</b> to submit <a href="https://github.com/ryanve/action">action</a> to WPORG are to: </div><div><ol style><li style>prevent incorrect dashboard updates from a conflicting WPORG theme<br></li>
<li style>prevent overall name confusion<br></li><li style>enable updates via Dashboard -> Updates<br></li><li style>enable installs via Appearance -> Themes </li></ol></div><div style>Is there an official way to solve #1 and #2 from outside WPORG? #3 and #4 are pure convenience. For me it would mean maintaining SVN in addition to Github.</div>
<div style><br></div><div><b>Thanks</b> all for the solid feedback. I tried to <a href="http://themes.trac.wordpress.org/ticket/12206#comment:2">clarify all points in ticket #12206</a>. Note there is a <a href="http://themes.trac.wordpress.org/query?keywords=~theme-action">newer submission</a>. Itemized <a href="https://github.com/ryanve/action/commits/master">commits</a> are viewable by range like <a href="https://github.com/ryanve/action/compare/1.1.7...1.2.11">1.1.7...1.2.11</a> and relevant <a href="https://github.com/ryanve/action/issues">issues are here</a>.<br>
</div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><a href="http://twitter.com/ryanve" target="_blank">@ryanve</a> | 646-853-4941 | <a href="http://ryanvanetten.com/" target="_blank">ryanve.com</a> <br>
<div><br></div></div>
<br><br><div class="gmail_quote">On Wed, May 22, 2013 at 5:21 PM, Andrew Nacin <span dir="ltr"><<a href="mailto:wp@andrewnacin.com" target="_blank">wp@andrewnacin.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="im">On Wed, May 22, 2013 at 4:02 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br></div><div class="gmail_extra">
<div class="gmail_quote"><div class="im">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">The issue of passing anonymous functions to hooks is certainly valid. Hooks must reference a valid callback, so that they can be overridden.<div>
<br></div><div>Another major concern is that the Theme *requires* a PHP version higher than that required by WordPress core.</div></div></blockquote><div><br></div></div><div>If a theme cannot safely activate on the minimum version of PHP required by WordPress, then it has no place in the directory.</div>
<div><br></div><div>In core, I don't think we "sandbox" themes the way we do plugins. If this triggers fatal errors in 5.2, that's a no-no. The only alternative would be for it to switch back to the previous theme if it cannot run in 5.2. It looks like this theme does do this: <a href="http://themes.svn.wordpress.org/action/1.1.7/functions.php" target="_blank">http://themes.svn.wordpress.org/action/1.1.7/functions.php</a></div>
<div><br></div><div>The big problem with using PHP closures in a theme is that a child theme (or a plugin) cannot remove_action() or that add_action( $hook, function() { ... } ) call. (Same goes for remove_filter() and add_filter().) Even when core moves to PHP 5.3, we will not use closures in this way. They just aren't compatible with our simplistic hook API.</div>
<div><br></div><div>I don't think that is a reason to reject this theme. But I'm not sure such a developer-oriented theme has much of a place in the generic user-oriented themes directory. I would be interested to see if ryanve (the developer) ultimately agrees it should stay on GitHub.</div>
<span class="HOEnZb"><font color="#888888">
<div><br></div><div>Nacin</div></font></span></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>