[theme-reviewers] Theme Review Challenge and Second Opinion

[Chip Bennett]

By the way, I'll share this with the list, rather than in-ticket. As per
the Codex, the best-practice implementation to add a "parent" class to
wp_nav_menu() list items is to filter wp_nav_menu_objects. I recently used
this method, myself:

function oenology_add_menu_parent_class( $items ) {

	$parents = array();
	foreach ( $items as $item ) {
		if ( $item->menu_item_parent && $item->menu_item_parent > 0 ) {
			$parents[] = $item->menu_item_parent;
		}
	}

	foreach ( $items as $item ) {
		if ( in_array( $item->ID, $parents ) ) {
			$item->classes[] = 'menu-item-parent';
		}
	}

	return $items;
}
add_filter( 'wp_nav_menu_objects', 'oenology_add_menu_parent_class' );


I would recommend this method rather than using jQuery, though I'm not sure
about it being *required*.


On Tue, Mar 19, 2013 at 9:22 PM, Chip Bennett <chip at chipbennett.net> wrote:

> Hi Bryan,
>
> I'll be happy to take a look at this. Can you comment in-ticket first, so
> that I can follow up on your responses to the original reviewer?
>
> Thanks,
>
> Chip
>
>
> On Tue, Mar 19, 2013 at 9:19 PM, Bryan Hadaway <bhadaway at gmail.com> wrote:
>
>> http://themes.trac.wordpress.org/ticket/11498
>>
>> Theme was not approved over several misunderstandings of recommended vs
>> required. A lot of this stuff we've already gone over.
>>
>> Issues for not-approved:
>>
>> - *Licensing*. All 3rd party/licensed scripts already do contain the
>> proper license info. Do I still need to add a license.txt in addition?
>>
>> - *Inline Styles*. Recommended not to use, but not required. I recall
>> this discussion.
>>
>> - *Site Title*. The site title does show in plain text if no logo/header
>> is set. I have no problem with this in my testing, works fine.
>>
>> So, the only thing I think might need to be added is a license.txt, only
>> if required in addition to the scripts themselves already containing the
>> license info. Which is fine, but can I get an admin to approve this theme
>> or take it over and I'll upload the new version based on your instruction.
>>
>> Thanks
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130319/c4815399/attachment-0001.htm>