<div dir="ltr">By the way, I'll share this with the list, rather than in-ticket. As per the Codex, the best-practice implementation to add a "parent" class to wp_nav_menu() list items is to filter wp_nav_menu_objects. I recently used this method, myself:<div>
<br></div><div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><div style><pre style="margin-top:0px;margin-bottom:0px;padding:0px;border:0px;font-size:12px;font-family:Consolas,'Liberation Mono',Courier,monospace;color:rgb(51,51,51);line-height:16px">
<div class="" id="LC36" style="margin:0px;padding:0px 0px 0px 10px;border:0px"><span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">function</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(153,0,0);font-weight:bold">oenology_add_menu_parent_class</span><span class="" style="margin:0px;padding:0px;border:0px">(</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$items</span> <span class="" style="margin:0px;padding:0px;border:0px">)</span> <span class="" style="margin:0px;padding:0px;border:0px">{</span></div>
<div class="" id="LC37" style="margin:0px;padding:0px 0px 0px 10px;border:0px"><br></div><div class="" id="LC38" style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$parents</span> <span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">=</span> <span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">array</span><span class="" style="margin:0px;padding:0px;border:0px">();</span></div>
<div class="" id="LC39" style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">foreach</span> <span class="" style="margin:0px;padding:0px;border:0px">(</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$items</span> <span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">as</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$item</span> <span class="" style="margin:0px;padding:0px;border:0px">)</span> <span class="" style="margin:0px;padding:0px;border:0px">{</span></div>
<div class="" id="LC40" style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">if</span> <span class="" style="margin:0px;padding:0px;border:0px">(</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$item</span><span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">-></span><span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">menu_item_parent</span> <span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">&&</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$item</span><span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">-></span><span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">menu_item_parent</span> <span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">></span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,153,153)">0</span> <span class="" style="margin:0px;padding:0px;border:0px">)</span> <span class="" style="margin:0px;padding:0px;border:0px">{</span></div>
<div class="" id="LC41" style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$parents</span><span class="" style="margin:0px;padding:0px;border:0px">[]</span> <span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">=</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$item</span><span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">-></span><span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">menu_item_parent</span><span class="" style="margin:0px;padding:0px;border:0px">;</span></div>
<div class="" id="LC42" style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span class="" style="margin:0px;padding:0px;border:0px">}</span></div><div class="" id="LC43" style="margin:0px;padding:0px 0px 0px 10px;border:0px">
<span class="" style="margin:0px;padding:0px;border:0px">}</span></div><div class="" id="LC44" style="margin:0px;padding:0px 0px 0px 10px;border:0px"><br></div><div class="" id="LC45" style="margin:0px;padding:0px 0px 0px 10px;border:0px">
<span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">foreach</span> <span class="" style="margin:0px;padding:0px;border:0px">(</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$items</span> <span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">as</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$item</span> <span class="" style="margin:0px;padding:0px;border:0px">)</span> <span class="" style="margin:0px;padding:0px;border:0px">{</span></div>
<div class="" id="LC46" style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">if</span> <span class="" style="margin:0px;padding:0px;border:0px">(</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,134,179)">in_array</span><span class="" style="margin:0px;padding:0px;border:0px">(</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$item</span><span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">-></span><span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">ID</span><span class="" style="margin:0px;padding:0px;border:0px">,</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$parents</span> <span class="" style="margin:0px;padding:0px;border:0px">)</span> <span class="" style="margin:0px;padding:0px;border:0px">)</span> <span class="" style="margin:0px;padding:0px;border:0px">{</span></div>
<div class="" id="LC47" style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$item</span><span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">-></span><span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">classes</span><span class="" style="margin:0px;padding:0px;border:0px">[]</span> <span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">=</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(221,17,68)">'menu-item-parent'</span><span class="" style="margin:0px;padding:0px;border:0px">;</span> </div>
<div class="" id="LC48" style="margin:0px;padding:0px 0px 0px 10px;border:0px"> <span class="" style="margin:0px;padding:0px;border:0px">}</span></div><div class="" id="LC49" style="margin:0px;padding:0px 0px 0px 10px;border:0px">
<span class="" style="margin:0px;padding:0px;border:0px">}</span></div><div class="" id="LC50" style="margin:0px;padding:0px 0px 0px 10px;border:0px"><br></div><div class="" id="LC51" style="margin:0px;padding:0px 0px 0px 10px;border:0px">
<span class="" style="margin:0px;padding:0px;border:0px;font-weight:bold">return</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(0,128,128)">$items</span><span class="" style="margin:0px;padding:0px;border:0px">;</span> </div>
<div class="" id="LC52" style="margin:0px;padding:0px 0px 0px 10px;border:0px"><span class="" style="margin:0px;padding:0px;border:0px">}</span></div><div class="" id="LC53" style="margin:0px;padding:0px 0px 0px 10px;border:0px">
<span class="" style="margin:0px;padding:0px;border:0px">add_filter</span><span class="" style="margin:0px;padding:0px;border:0px">(</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(221,17,68)">'wp_nav_menu_objects'</span><span class="" style="margin:0px;padding:0px;border:0px">,</span> <span class="" style="margin:0px;padding:0px;border:0px;color:rgb(221,17,68)">'oenology_add_menu_parent_class'</span> <span class="" style="margin:0px;padding:0px;border:0px">);</span></div>
</pre></div></blockquote></div><div><br></div><div style>I would recommend this method rather than using jQuery, though I'm not sure about it being *required*.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, Mar 19, 2013 at 9:22 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi Bryan,<div><br></div><div>I'll be happy to take a look at this. Can you comment in-ticket first, so that I can follow up on your responses to the original reviewer?</div><div><br></div><div>Thanks,</div>
<div><br></div><div>Chip</div></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div class="h5">On Tue, Mar 19, 2013 at 9:19 PM, Bryan Hadaway <span dir="ltr"><<a href="mailto:bhadaway@gmail.com" target="_blank">bhadaway@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><a href="http://themes.trac.wordpress.org/ticket/11498" target="_blank">http://themes.trac.wordpress.org/ticket/11498</a><br>
<br>Theme was not approved over several misunderstandings of recommended vs required. A lot of this stuff we've already gone over.<br>
<br>Issues for not-approved:<br><br>- <b>Licensing</b>. All 3rd party/licensed scripts already do contain the proper license info. Do I still need to add a license.txt in addition?<br><br>- <b>Inline Styles</b>. Recommended not to use, but not required. I recall this discussion.<br>
<br>- <b>Site Title</b>. The site title does show in plain text if no logo/header is set. I have no problem with this in my testing, works fine.<br><br>So, the only thing I think might need to be added is a license.txt, only if required in addition to the scripts themselves already containing the license info. Which is fine, but can I get an admin to approve this theme or take it over and I'll upload the new version based on your instruction.<br>
<br>Thanks<br>
<br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>