[theme-reviewers] Is adding Buddypress + bbpress support to theme is not allowed? what the hell?
Chip Bennett
chip at chipbennett.net
Fri Mar 15 13:47:38 UTC 2013
With respect to specific reviews, the purpose of this list is to *escalate*
issues that are not able to be resolved first *in-ticket*. If you disagree
with a specific review comment, or believe that the reviewer made a
mistake, then you need to discuss the issue in-ticket *first*, before
escalating it to the mail-list.
80% of your complaint could have been resolved with a simple, in-ticket
comment stating, "the /bbpress and /buddypress folders are just templates.
The Theme doesn't bundle the entire Plugin; it just provides integration
support for each."
Given that there are whitelisted keyword tags for bbpress and bluddypress,
I don't think there's anything to clarify. Obviously, Themes are allowed to
integrate support for either Plugin (or for any other Plugin, for that
matter).
Any and all translatable strings in the Theme must include the Theme's
declared translation textdomain.
On Fri, Mar 15, 2013 at 9:20 AM, Ünsal Korkmaz <unsalkorkmaz at gmail.com>wrote:
> I didnt curse anyone lol.. Isnt it this list's one of purpose? Discussion
> on theme reviewing? Sorry if its not allowed..
>
> So please lets clarify; basically bbpress and buddpress files are allowed
> but need theme translations right?
>
>
> On Fri, Mar 15, 2013 at 3:16 PM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> So, rather than coming immediately to the mailing list and start cursing,
>> why didn't you leave a comment in-ticket, to clarify that the /bbpress and
>> /buddypress files are merely templates to integrate support for the bbPress
>> and BuddyPress Plugins?
>>
>> Reviewers are humans, and are merely volunteers. Please don't hold them
>> to a standard of perfection.
>>
>> As for the translation comment: it is correct and valid. If you include a
>> translatable string, you MUST provide a textdomain. You can't assume that
>> the string is and will always be included in the default textdomain.
>>
>>
>> On Fri, Mar 15, 2013 at 8:42 AM, Ünsal Korkmaz <unsalkorkmaz at gmail.com>wrote:
>>
>>> Check review: http://themes.trac.wordpress.org/ticket/11668
>>>>
>>>> There are different directories in the theme like bbpress, forums,
>>>> groups, members, registration and i am unable to find any usage of them in
>>>> the theme. Please explain there usage in the *readme* file. bbpress is
>>>> a Plugin territory.
>>>
>>>
>>> I want to believe this is a wrong review. I cant believe supporting
>>> buddypress or bbress can be territory.
>>>
>>>
>>>> There are several text domain problems in the theme. You should try
>>>> find all and fix theme e.g.
>>>>
>>>> - Text domain problems in single_full-page.php. You have not
>>>> included a text domain!
>>>>
>>>> And is using <?php _e( 'Permalink' ); ?> wrong? Its default wordpress
>>> language support, how can it be a problem? Why people needto translate it
>>> for every theme? what the hell?
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130315/53ddec76/attachment.htm>
More information about the theme-reviewers
mailing list