[theme-reviewers] Is adding Buddypress + bbpress support to theme is not allowed? what the hell?

Ünsal Korkmaz unsalkorkmaz at gmail.com
Fri Mar 15 13:20:47 UTC 2013


I didnt curse anyone lol.. Isnt it this list's one of purpose? Discussion
on theme reviewing? Sorry if its not allowed..

So please lets clarify; basically bbpress and buddpress files are allowed
but need theme translations right?

On Fri, Mar 15, 2013 at 3:16 PM, Chip Bennett <chip at chipbennett.net> wrote:

> So, rather than coming immediately to the mailing list and start cursing,
> why didn't you leave a comment in-ticket, to clarify that the /bbpress and
> /buddypress files are merely templates to integrate support for the bbPress
> and BuddyPress Plugins?
>
> Reviewers are humans, and are merely volunteers. Please don't hold them to
> a standard of perfection.
>
> As for the translation comment: it is correct and valid. If you include a
> translatable string, you MUST provide a textdomain. You can't assume that
> the string is and will always be included in the default textdomain.
>
>
> On Fri, Mar 15, 2013 at 8:42 AM, Ünsal Korkmaz <unsalkorkmaz at gmail.com>wrote:
>
>> Check review: http://themes.trac.wordpress.org/ticket/11668
>>>
>>> There are different directories in the theme like bbpress, forums,
>>> groups, members, registration and i am unable to find any usage of them in
>>> the theme. Please explain there usage in the *readme* file. bbpress is
>>> a Plugin territory.
>>
>>
>> I want to believe this is a wrong review. I cant believe supporting
>> buddypress or bbress can be territory.
>>
>>
>>> There are several text domain problems in the theme. You should try find
>>> all and fix theme e.g.
>>>
>>>    - Text domain problems in single_full-page.php. You have not
>>>    included a text domain!
>>>
>>> And is using <?php _e( 'Permalink' ); ?> wrong? Its default wordpress
>> language support, how can it be a problem? Why people needto translate it
>> for every theme? what the hell?
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130315/312baee6/attachment.htm>


More information about the theme-reviewers mailing list