[theme-reviewers] Tinymce button that only adds css codes.. still plugin territory?

[Otto]

On Sun, Mar 3, 2013 at 12:59 PM, Ünsal Korkmaz <unsalkorkmaz at gmail.com> wrote:
> Tinymce button is just adding "btn" class to <a> tag when click.

Okay, so it's styling a link to look like a button.

In what way is this behavior specific to your theme?

The point Chip and others are making is that while a theme can
technically do anything a plugin can, their purposes are different. If
a user wants to display links as buttons, then they would likely use a
plugin for that, because such a plugin could work on any theme.

Additionally, having your buttons turn back into normal links when you
changed themes would be undesirable.

Everything in the theme should be theme-specific. If you're adding
some kind of functionality to change the actual user-entered content
(in this case, adding a "btn" class), and having that change in said
content mean something for that content (the link should be shown as a
button), then it should probably be in a plugin so that it is
universally available and won't disappear just because the user
switched themes.

If, on the other hand, the change doesn't make sense outside of your
theme, then there is a case to be argued. But you're arguing for
"generic" cases, and such cases which can be universal across many
themes almost always belong in plugins.

-Otto