[theme-reviewers] Questions on my first review

Justin Tadlock justin at justintadlock.com
Wed Jun 12 23:37:55 UTC 2013


Cool.  I'm glad you clarified what you meant with compression because 
I'm sure that would've been misunderstood at some point because 
minification/compression are often used interchangeably (though not the 
same thing).

On 6/12/2013 5:43 PM, Chip Bennett wrote:
> If someone wants to make an argument for the presentational nature of 
> content-sharing buttons in their Theme, I'd be fine with that. I just 
> wasn't quite sure how to write that into the Guidelines as such.
>
> Making a style.min.css isn't compression; it's just removal of 
> whitespace, and is perfectly just fine.
>
>
> On Wed, Jun 12, 2013 at 6:17 PM, Justin Tadlock 
> <justin at justintadlock.com <mailto:justin at justintadlock.com>> wrote:
>
>     I'm just really not getting why "Content Sharing buttons/links" is
>     now not allowed.  These things can very much be presentational in
>     nature.  If any theme developer wanted to make custom sharing
>     buttons/links or design them specifically for their theme, I don't
>     have a problem with it.  They tend to work much better this way
>     than via a plugin because they fit within the design better.
>
>     I'm a big fan of these being in a plugin, but I don't have a
>     problem with theme authors adding this at all.
>
>     ***
>
>     As for "Resource compression/caching", I don't see an issue with
>     this in some respects.  For example, I often make ".min" versions
>     of JS and CSS files (I include the non-compressed files too).  I
>     consider it good practice to cut back on file sizes on the front end.
>
>     If we're talking about building in our own WP Minify plugin into
>     the theme, that's a different story.
>
>
>     On 6/12/2013 4:59 PM, Merci Javier wrote:
>>
>>     Thank you Chip. Second what Thomas posted. No ambiguity there :-)
>>
>>     Mercime
>>
>>
>>     On Wed, Jun 12, 2013 at 12:45 PM, Thomas from ThemeZee
>>     <contact at themezee.com <mailto:contact at themezee.com>> wrote:
>>
>>         Wow, thanks Chip for editing the Guidelines and adding these
>>         clarifications.
>>
>>         I guess there will be a lot discussions now what exactly
>>         should be allowed and what not. Maybe this will lead to some
>>         adjustments of the guidelines, too.
>>
>>         But we had most of these discussions already and it was
>>         talked about plugin territory stuff over and over again. Now
>>         the results of these discussion are written down, which makes
>>         all rules consistent and everyone can look them up.
>>
>>         Really great improvement :)
>>
>>
>>
>>
>>     _______________________________________________
>>     theme-reviewers mailing list
>>     theme-reviewers at lists.wordpress.org  <mailto:theme-reviewers at lists.wordpress.org>
>>     http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>     _______________________________________________
>     theme-reviewers mailing list
>     theme-reviewers at lists.wordpress.org
>     <mailto:theme-reviewers at lists.wordpress.org>
>     http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130612/20d1c235/attachment-0001.html>


More information about the theme-reviewers mailing list