[theme-reviewers] Theme Review Help

Chip Bennett chip at chipbennett.net
Thu Jul 11 17:08:18 UTC 2013


No. Calling the_excerpt() by default doesn't output a more *link*.

If the Theme filters excerpt_more, to include a link, then that link needs
to work properly.


On Thu, Jul 11, 2013 at 1:05 PM, carolina poena <myazalea at hotmail.com>wrote:

> Is the more function required if the (index) is only showing excerpts?
>
> ------------------------------
> Date: Thu, 11 Jul 2013 12:54:19 -0400
> From: chip at chipbennett.net
> To: theme-reviewers at lists.wordpress.org
> Subject: Re: [theme-reviewers] Theme Review Help
>
>
> Design aesthetic would usually dictate what method is used to handle long,
> non-breaking text. The critical concern is that long, non-breaking text
> doesn't *break* the layout.
>
> "More" function does need to function properly.
>
> Handling of a given menu size is also part of design aesthetic, though it
> is appropriate to require the developer to include any unusual limitations
> (such as "primary menu only supports 5 top-level menu items") in the Theme
> documentation (i.e. readme file) so that the end user is aware.
>
> The number and severity of these issues is such that I would list them as
> *required*, but approve the ticket on the basis that they be addressed in
> the next Theme revision.
>
>
> On Thu, Jul 11, 2013 at 12:49 PM, Siobhan Bamber <siobhanbamber at gmail.com>wrote:
>
> Hi everyone,
>
> I'm going through the individual post unit tests for a theme I've been
> assigned and have a few questions.
>
> I've come across these issues in the individual posts unit test:
>
> - Long non-breaking text is cut off. Should make use of the “word-wrap”
> CSS property in order to prevent this.
>
> - “More” tag does not function in blog posts.
>
> - Dropdown menus with a high depth of submenus can go off-screen.
>
> These are the only errors I could find. The theme seems to pass in terms
> of code quality etc. In your opinion, are the errors I found big enough to
> constitute a "Not-Approved" status?
>
> Many thanks.
>
> Siobhan
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________ theme-reviewers mailing
> list theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130711/3b5d1213/attachment.html>


More information about the theme-reviewers mailing list