[theme-reviewers] wp.com compability

[Otto]

Did you try asking the author in the ticket? They get those responses
emailed to them, and you don't have to complete the review all at
once.

However, I expect that is there in order to load the wp-com specific
code if it exists. They use separate versions of themes on the wp-com
side, but have trying to make things more generic and easier to
release.

So on the whole, I'd say that sort of code is fine. It's just a hook
for them to put in specialized code for their use case, does nothing
outside of that case.

-Otto


On Thu, Jul 4, 2013 at 12:18 PM, carolina poena <myazalea at hotmail.com> wrote:
>
> Are we talking about the same thing? :)
> In this case the file really isnt there. But it only loads if it IS so it
> cant really cause any problems.
> I don't expect problems -it's an automattic theme, already available on
> wordpress.com, but to really review this I need more knowledge/information
> :)
> I'm not sure its converted properly for wordpress.org.
>
> Ticket is http://themes.trac.wordpress.org/ticket/12902
>
>
> ________________________________
> From: jasper at planetkips.nl
> Date: Thu, 4 Jul 2013 18:16:27 +0200
> To: theme-reviewers at lists.wordpress.org
> Subject: Re: [theme-reviewers] wp.com compability
>
>
> They actually are in the template, or theme,  directory -that's the call to
> get_template_directory. So the theme is self contained.
> Sincerely,
>
> Jasper Kips
>
>
> Op 4 jul. 2013, om 17:45 heeft carolina poena <myazalea at hotmail.com> het
> volgende geschreven:
>
> I've seen some themes with references to wp.com, not only in automattic
> themes,
> are snippets like these supposed to remain in the standalone theme? Maybe
> this have to do with jetpack?
> (the file doestn exist within the theme)
>
>  /**
>  * Load WP.com compatibility file.
>  */
> if ( file_exists( get_template_directory() . '/inc/wpcom.php' ) )
> require get_template_directory() . '/inc/wpcom.php';
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________ theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>