[theme-reviewers] Need A Final Call

[Philip M. Hofer (Frumph)]

1. Follow how twenty-twelve theme does it, at the top of the functions.php outside of an action call; I would add global $content_width before it

global $content_width;
if ( ! isset( $content_width ) )
    $content_width = 520;

2.  Again follow how twenty-twelve does it, make a function do the enqueues then add an action


From: Qamar Ashraf 
Sent: Monday, January 21, 2013 5:34 AM
To: theme-reviewers at lists.wordpress.org 
Subject: [theme-reviewers] Need A Final Call

Hello Admin,
I need a final call on the following topics as there are different views by different reviewers,

1. About $content_width

What is the best place for the $content_width

A. Wrap $content_width definition in a callback, hooked into after_setup_theme - ( I am reviewing on this point )
B. Placing $content_width outside a function 

2. About IE Conditional Tags / Scripts like HTML 5 Shiv

A. - Additional scripts should not be hard-coded in the header template. The most appropriate way to handle them to place it in a function that hooks into wp_head. ( I am reviewing on this point )
B. Can be placed directly in header.php

Waiting for response.

-- 
Regards 
Qamar Ashraf
Project Manager
www.tutorialchip.com
www.freestockphotosclub.com
www.twunfollowapp.com
@lifeobject1


--------------------------------------------------------------------------------
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130121/25b32383/attachment.htm>