[theme-reviewers] Theme check acting up?

[Otto]

Yeah, that plugin code there was kind bad. Parts of it were clearly
broken. I didn't check those files yesterday because I've never modified
them. All I ever changed was the check functions themselves, that's all we
use on WordPress.org, the interface part of the plugin is not run there.

So I've repaired the conditional pass/fail code. For some reason, that code
was doing it completely wrong and checking the error messages instead of
the result from the checks themselves. Also, the tc_trac() function was
messed up. Surprised that code ever worked.

Releasing a new version now for a quick fix.

-Otto



On Fri, Dec 13, 2013 at 1:57 PM, Bruce Wampler <weavertheme at gmail.com>wrote:

> Theme Check Plugin is not working for me at all with 3.8 - it is passing
> everything I throw at it - fopen, extra .files, recommended.
>
> But the check version on upload finds the errors.
>
>
> On Fri, Dec 13, 2013 at 7:45 AM, Otto <otto at ottodestruct.com> wrote:
>
>> Why would md5 set off an error in theme check? I don't understand.
>> There's no check for "md5" anywhere.
>>
>> -Otto
>>
>>
>>
>> On Fri, Dec 13, 2013 at 7:59 AM, Edward Caissie <edward.caissie at gmail.com
>> > wrote:
>>
>>> @Daniel - It will always complain about DEBUG set to false, it's suppose
>>> to as a reminder you should have it on ... especially when testing.
>>>
>>> As far as the md5 issue, I couldn't say but if you find it is an issue
>>> and can sort out a solution I imagine Otto would appreciate you saving him
>>> some time working on it.
>>>
>>> Edward Caissie
>>> aka Cais.
>>>
>>>
>>> On Fri, Dec 13, 2013 at 4:34 AM, Daniel <danielx386 at gmail.com> wrote:
>>>
>>>> Ok did clean install on localhost and same deal. When I get fully
>>>> online I will try on a real live server.
>>>>
>>>> On 12/13/13, Emil Uzelac <emil at uzelac.me> wrote:
>>>> > Wild guess, something off in your settings. Please try live server if
>>>> you
>>>> > didn't already :-D
>>>> > On Dec 13, 2013 2:33 AM, "Daniel" <danielx386 at gmail.com> wrote:
>>>> >
>>>> >> To test it I put in a md5 function and it didn't set it off for me
>>>> and
>>>> >> it will complain if wp_debug is not on.
>>>> >>
>>>> >> On 12/13/13, Emil Uzelac <emil at uzelac.me> wrote:
>>>> >> > Doesn't seem to be broken from my end. Otto will confirm, or...
>>>> >> > On Dec 13, 2013 2:18 AM, "Daniel" <danielx386 at gmail.com> wrote:
>>>> >> >
>>>> >> >> Please excuse me as I am on my phone but I got a funny feeling
>>>> that
>>>> >> >> the theme check is somewhat broken as it saying that everything is
>>>> >> >> alright with my theme when the last version reported errors. I am
>>>> >> >> running wordpress 3.8 with latest theme check.
>>>> >> >>
>>>> >> >> --
>>>> >> >> Regards,
>>>> >> >> Daniel Fenn
>>>> >> >> _______________________________________________
>>>> >> >> theme-reviewers mailing list
>>>> >> >> theme-reviewers at lists.wordpress.org
>>>> >> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>> >> >>
>>>> >> >
>>>> >>
>>>> >>
>>>> >> --
>>>> >> Regards,
>>>> >> Daniel Fenn
>>>> >> _______________________________________________
>>>> >> theme-reviewers mailing list
>>>> >> theme-reviewers at lists.wordpress.org
>>>> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>> >>
>>>> >
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Daniel Fenn
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20131213/3927ec7a/attachment-0001.html>