<div dir="ltr">Yeah, that plugin code there was kind bad. Parts of it were clearly broken. I didn't check those files yesterday because I've never modified them. All I ever changed was the check functions themselves, that's all we use on WordPress.org, the interface part of the plugin is not run there.<div>
<br></div><div>So I've repaired the conditional pass/fail code. For some reason, that code was doing it completely wrong and checking the error messages instead of the result from the checks themselves. Also, the tc_trac() function was messed up. Surprised that code ever worked.<div>
<br></div><div>Releasing a new version now for a quick fix. </div></div><div class="gmail_extra"><br clear="all"><div>-Otto</div>
<div class="gmail_extra"><br></div><br><br><div class="gmail_quote">On Fri, Dec 13, 2013 at 1:57 PM, Bruce Wampler <span dir="ltr"><<a href="mailto:weavertheme@gmail.com" target="_blank">weavertheme@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div>Theme Check Plugin is not working for me at all with 3.8 - it is passing everything I throw at it - fopen, extra .files, recommended.<br><br></div>But the check version on upload finds the errors.<br>
</div>
<div><div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 13, 2013 at 7:45 AM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">Why would md5 set off an error in theme check? I don't understand. There's no check for "md5" anywhere.<div class="gmail_extra"><span><font color="#888888"><br clear="all"><div>
-Otto</div></font></span><div><div>
<div class="gmail_extra"><br></div><br><br><div class="gmail_quote">On Fri, Dec 13, 2013 at 7:59 AM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">@Daniel - It will always complain about DEBUG set to false, it's suppose to as a reminder you should have it on ... especially when testing.<div><br></div><div>As far as the md5 issue, I couldn't say but if you find it is an issue and can sort out a solution I imagine Otto would appreciate you saving him some time working on it.</div>
<span><font color="#888888">
</font></span></div><div class="gmail_extra"><span><font color="#888888"><br clear="all"><div>Edward Caissie<br>aka Cais.</div></font></span><div><div>
<br><br><div class="gmail_quote">On Fri, Dec 13, 2013 at 4:34 AM, Daniel <span dir="ltr"><<a href="mailto:danielx386@gmail.com" target="_blank">danielx386@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Ok did clean install on localhost and same deal. When I get fully<br>
online I will try on a real live server.<br>
<div><div><br>
On 12/13/13, Emil Uzelac <<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>> wrote:<br>
> Wild guess, something off in your settings. Please try live server if you<br>
> didn't already :-D<br>
> On Dec 13, 2013 2:33 AM, "Daniel" <<a href="mailto:danielx386@gmail.com" target="_blank">danielx386@gmail.com</a>> wrote:<br>
><br>
>> To test it I put in a md5 function and it didn't set it off for me and<br>
>> it will complain if wp_debug is not on.<br>
>><br>
>> On 12/13/13, Emil Uzelac <<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>> wrote:<br>
>> > Doesn't seem to be broken from my end. Otto will confirm, or...<br>
>> > On Dec 13, 2013 2:18 AM, "Daniel" <<a href="mailto:danielx386@gmail.com" target="_blank">danielx386@gmail.com</a>> wrote:<br>
>> ><br>
>> >> Please excuse me as I am on my phone but I got a funny feeling that<br>
>> >> the theme check is somewhat broken as it saying that everything is<br>
>> >> alright with my theme when the last version reported errors. I am<br>
>> >> running wordpress 3.8 with latest theme check.<br>
>> >><br>
>> >> --<br>
>> >> Regards,<br>
>> >> Daniel Fenn<br>
>> >> _______________________________________________<br>
>> >> theme-reviewers mailing list<br>
>> >> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>> >> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>> >><br>
>> ><br>
>><br>
>><br>
>> --<br>
>> Regards,<br>
>> Daniel Fenn<br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>
><br>
<br>
<br>
--<br>
Regards,<br>
Daniel Fenn<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div>