[theme-reviewers] Printing JavaScript in footer

[devcorn]

I second  Justin, just for three lines.. call to a function doesn't make
any sense.


On Sat, Aug 3, 2013 at 11:47 PM, Justin Tadlock <justin at justintadlock.com>wrote:

>  Printing JS like that should be perfectly fine.  I see no reason to load
> 3 lines of jQuery as a completely separate file and probably wouldn't
> consider it best practice to do so.
>
>
> On 8/3/2013 12:09 PM, Edward Caissie wrote:
>
>  I would strongly lean towards REQUIRED ... mostly for consistency when
> and where scripts are enqueued.
>
>  Other than that I would say RECOMMENDED as a best practice ideal at a
> minimum.
>
> Edward Caissie
> aka Cais.
>
>
> On Sat, Aug 3, 2013 at 1:02 PM, Chip Bennett <chip at chipbennett.net> wrote:
>
>> Agree, but it's added as a callback to wp_footer() - so is it a
>> *recommended* or *required* aspect that it be enqueued via
>> wp_enqueue_script()?
>>
>>
>>  On Sat, Aug 3, 2013 at 12:03 PM, Edward Caissie <
>> edward.caissie at gmail.com> wrote:
>>
>>> That script can, and more importantly *should* be enqueued.
>>>
>>> Edward Caissie
>>> aka Cais.
>>>
>>>
>>>  On Sat, Aug 3, 2013 at 11:54 AM, Harish <me at harishchouhan.com> wrote:
>>>
>>>>   Hi,
>>>>
>>>>
>>>>
>>>> I have seen many premium themes doing this. Not a good practise so I
>>>> would not recommend it.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> Regards,
>>>>
>>>> Harish Chouhan
>>>>
>>>>
>>>>
>>>> *Visit me at *- www.harishchouhan.com
>>>> Phone: +91-9833661410 | Email: me at harishchouhan.com
>>>>
>>>>
>>>>
>>>> *From:* theme-reviewers [mailto:
>>>> theme-reviewers-bounces at lists.wordpress.org] *On Behalf Of *Ola Laczek
>>>> *Sent:* Sat 03 August 13 09:16 PM
>>>> *To:* theme-reviewers at lists.wordpress.org
>>>> *Subject:* [theme-reviewers] Printing JavaScript in footer
>>>>
>>>>
>>>>
>>>> Hello!
>>>>
>>>>
>>>>
>>>> I'm reviewing a theme that prints javascript in the footer from
>>>> functions.php like this:
>>>>
>>>>
>>>>
>>>> add_action('wp_footer', 'flex_init');
>>>>
>>>> function flex_init() {
>>>>
>>>>      echo '<script type="text/javascript">
>>>>
>>>>     jQuery(document).ready(function() {
>>>>
>>>>         jQuery("#slider").flexslider();
>>>>
>>>>      });
>>>>
>>>>      </script>';
>>>>
>>>> }
>>>>
>>>>
>>>>
>>>> Is this ok, or should I tell this person to create separate javascript
>>>> file, put this code there and enqueue like other scripts?
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> Best regards,
>>>> Ola Łączek
>>>>
>>>>
>>>>
>>>>  _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
>
> _______________________________________________
> theme-reviewers mailing listtheme-reviewers at lists.wordpress.orghttp://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130803/bba567b8/attachment.html>