<div dir="ltr">I second Justin, just for three lines.. call to a function doesn't make any sense.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Aug 3, 2013 at 11:47 PM, Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Printing JS like that should be perfectly fine. I see no reason to
load 3 lines of jQuery as a completely separate file and probably
wouldn't consider it best practice to do so.<div><div class="h5"><br>
<br>
<div>On 8/3/2013 12:09 PM, Edward Caissie
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>I would strongly lean towards REQUIRED ... mostly for
consistency when and where scripts are enqueued.<br>
<br>
</div>
Other than that I would say RECOMMENDED as a best practice ideal
at a minimum.<br>
</div>
<div class="gmail_extra"><br clear="all">
<div>Edward Caissie<br>
aka Cais.</div>
<br>
<br>
<div class="gmail_quote">On Sat, Aug 3, 2013 at 1:02 PM, Chip
Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Agree, but it's added as a callback to
wp_footer() - so is it a *recommended* or *required*
aspect that it be enqueued via wp_enqueue_script()?</div>
<div>
<div>
<div class="gmail_extra">
<br>
<br>
<div class="gmail_quote">
On Sat, Aug 3, 2013 at 12:03 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">That script can, and more
importantly *should* be enqueued.<br>
</div>
<div class="gmail_extra"><br clear="all">
<div>Edward Caissie<br>
aka Cais.</div>
<br>
<br>
<div class="gmail_quote">
<div>
<div>On Sat, Aug 3, 2013 at 11:54 AM, Harish
<span dir="ltr"><<a href="mailto:me@harishchouhan.com" target="_blank">me@harishchouhan.com</a>></span>
wrote:<br>
</div>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>
<div link="#0563C1" vlink="#954F72" lang="EN-IN">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi,</span></p>
<p class="MsoNormal">
<span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I
have seen many premium themes
doing this. Not a good practise
so I would not recommend it. </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#404040"> </span></p>
<p class="MsoNormal" style="line-height:150%"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#404040">Regards,</span></p>
<p class="MsoNormal" style="line-height:150%"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#404040">Harish
Chouhan</span></p>
<p class="MsoNormal" style="line-height:150%">
<span style="font-size:10.0pt;line-height:150%;font-family:"Arial","sans-serif";color:#404040"> </span></p>
<p class="MsoNormal" style="line-height:150%"><b><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#0d0d0d">Visit
me at </span></b><span style="font-size:16.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#0d0d0d">-
</span><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d"><a href="http://www.harishchouhan.com/" target="_blank"><span style="font-size:10.0pt;line-height:150%;color:black">www.harishchouhan.com</span></a></span><span style="font-size:10.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#0d0d0d">
</span><span style="font-size:16.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#0d0d0d"><br>
</span><span style="font-size:10.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#0d0d0d">Phone:
<a href="tel:%2B91-9833661410" value="+919833661410" target="_blank">+91-9833661410</a>
| Email: <a href="mailto:me@harishchouhan.com" target="_blank"><span style="color:black">me@harishchouhan.com</span></a>
</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" lang="EN-US">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"" lang="EN-US"> theme-reviewers
[mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>]
<b>On Behalf Of </b>Ola Laczek<br>
<b>Sent:</b> Sat 03 August 13
09:16 PM<br>
<b>To:</b> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<b>Subject:</b>
[theme-reviewers] Printing
JavaScript in footer</span></p>
<div>
<div>
<p class="MsoNormal"> </p>
<p class="MsoNormal">Hello!</p>
<div>
<p class="MsoNormal"> </p>
</div>
<div>
<p class="MsoNormal">I'm
reviewing a theme that
prints javascript in the
footer from functions.php
like this:</p>
</div>
<div>
<p class="MsoNormal"> </p>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><span>add_action('wp_footer',
'flex_init');</span></p>
</div>
<div>
<p class="MsoNormal"><span>function
flex_init() {</span></p>
</div>
<div>
<p class="MsoNormal"><span><span> </span></span><span>echo
'<script
type="text/javascript"></span></p>
</div>
<div>
<p class="MsoNormal"><span> <span>
</span>jQuery(document).ready(function()
{</span></p>
</div>
<div>
<p class="MsoNormal"><span>
jQuery("#slider").flexslider();</span></p>
</div>
<div>
<p class="MsoNormal"><span> <span>
</span> });</span></p>
</div>
<div>
<p class="MsoNormal"><span> <span>
</span></script>';</span></p>
</div>
<div>
<p class="MsoNormal"><span>}</span></p>
</div>
</div>
<div>
<p class="MsoNormal"> </p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">Is
this ok, or should I
tell this person to
create separate
javascript file, put
this code there and
enqueue like other
scripts?</span></p>
</div>
<div>
<p class="MsoNormal"> </p>
</div>
<div>
<p class="MsoNormal"> </p>
</div>
<p class="MsoNormal">Best
regards,<br>
Ola Łączek</p>
<div>
<p class="MsoNormal"> </p>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
</div>
</div>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>