[theme-reviewers] Adding warnings to Theme-Check for remove_filter on wpautop and wptexturize

[Chip Bennett]

Given that Themes should not be adding post-content shortcodes, removing
the wpautop filter from shortcodes should be a non-issue.

I concur with making this (and any other filter that Themes shouldn't be
removing) a *warning* level error.

Chip

On Wed, Sep 5, 2012 at 8:25 PM, Japheth Thomson <japh at envato.com> wrote:

> I think a "Warning" would be appropriate.
>
> There's more info on theme developer's perspectives (and also plugin
> developers towards the end) in this forum thread:
> http://themeforest.net/forums/thread/wpautop/70057
>
>
> On 6 September 2012 11:16, Justin Tadlock <justin at justintadlock.com>wrote:
>
>>  If adding something to Theme Check, it should just be a "Warning" (or is
>> it "Info"?) basically to let the reviewer know to look into it.
>>
>> But, just for discussion, should PageLines and Tenacity even be doing
>> this?  It sounds like plugin territory to me.  Admittedly, I haven't
>> checked into the themes' code, so there might be a good reason for it that
>> deals with theme functionality.
>>
>>
>> On 9/5/2012 7:59 PM, Edward Caissie wrote:
>>
>> This Google search (for the last year) site:themes.svn.wordpress.org"remove_filter( 'the_content', 'wpautop' )" brings up 5 results.
>>
>> I haven't really looked closely to see what all the repercussions of
>> doing it would be, but at a glance I am not seeing it as being wrong given
>> what the theme is trying to do. For example, PageLines is simply moving the
>> two functions to a different priority sequence (from the default 10 to 12)
>> to "Prevent AUTOP inside of shortcodes"
>>
>> ... and the Tenacity theme appears to be removing these formatting
>> functions in favor of their own.
>>
>> Perhaps there is a better method? I'm sure this could be opened for
>> discussion but as I see from these recent examples, it appears (at least
>> with these two randomly picked from the search results) to be done in a
>> conscientious manner.
>>
>>
>> Cais.
>>
>>
>> On Wed, Sep 5, 2012 at 8:50 PM, Japheth Thomson <japh at envato.com> wrote:
>>
>>> Yeah, it seems strange. There's a tutorial here:
>>> http://tutorials.mysitemyway.com/adding-column-layout-shortcodes-to-a-wordpress-theme/#highlighter_671922which seems to claim that the <p></p> and <br /> tags mess with column
>>> shortcodes, or something like that?
>>>
>>>
>>> On 6 September 2012 10:47, Justin Tadlock <justin at justintadlock.com>wrote:
>>>
>>>>  I can't really think of a reason a theme should be doing either of
>>>> those things at all.  There might be some legitimate uses (from a theme
>>>> perspective) but none come to mind at the moment.
>>>>
>>>>
>>>> On 9/5/2012 7:27 PM, Japheth Thomson wrote:
>>>>
>>>>  Hello,
>>>>
>>>>  There's been some discussion today on Twitter, and a blog post I
>>>> wrote ( http://japh.co/NSXyTr ), about themes that run code like:
>>>>
>>>>  remove_filter( 'the_content', 'wpautop' );
>>>>
>>>> remove_filter( 'the_content', 'wptexturize' );
>>>>
>>>>
>>>>  And also implementing a [raw][/raw] shortcode like
>>>> http://wordpress.org/support/topic/plugin-remove-wpautop-wptexturize-with-a-shortcode
>>>>
>>>>  Could we add checks for these things into Theme-Check? And would it
>>>> be sensible to do so?
>>>>
>>>>  Cheers,
>>>> Japh
>>>>
>>>>  --
>>>> Japh Thomson
>>>> WordPress Evangelist
>>>> japh at envato.com
>>>> http://envato.com
>>>> http://twitter.com/envato
>>>>
>>>>
>>>>
>>>>
>>>>  _______________________________________________
>>>> theme-reviewers mailing listtheme-reviewers at lists.wordpress.orghttp://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>>
>>>  --
>>> Japh Thomson
>>> WordPress Evangelist
>>> japh at envato.com
>>> http://envato.com
>>> http://twitter.com/envato
>>>
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing listtheme-reviewers at lists.wordpress.orghttp://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
>
> --
> Japh Thomson
> WordPress Evangelist
> japh at envato.com
> http://envato.com
> http://twitter.com/envato
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120905/301aa1a3/attachment.htm>