Given that Themes should not be adding post-content shortcodes, removing the wpautop filter from shortcodes should be a non-issue.<div><br></div><div>I concur with making this (and any other filter that Themes shouldn't be removing) a *warning* level error.</div>
<div><br></div><div>Chip<br><br><div class="gmail_quote">On Wed, Sep 5, 2012 at 8:25 PM, Japheth Thomson <span dir="ltr"><<a href="mailto:japh@envato.com" target="_blank">japh@envato.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I think a "Warning" would be appropriate.<div><br></div><div>There's more info on theme developer's perspectives (and also plugin developers towards the end) in this forum thread: <a href="http://themeforest.net/forums/thread/wpautop/70057" target="_blank">http://themeforest.net/forums/thread/wpautop/70057</a></div>
<div class="HOEnZb"><div class="h5">
<div><br></div><div><br><div class="gmail_quote">On 6 September 2012 11:16, Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
If adding something to Theme Check, it should just be a "Warning"
(or is it "Info"?) basically to let the reviewer know to look into
it.<br>
<br>
But, just for discussion, should PageLines and Tenacity even be
doing this? It sounds like plugin territory to me. Admittedly, I
haven't checked into the themes' code, so there might be a good
reason for it that deals with theme functionality.<div><div><br>
<br>
<div>On 9/5/2012 7:59 PM, Edward Caissie
wrote:<br>
</div>
<blockquote type="cite">This Google search (for the last year) site:<a href="http://themes.svn.wordpress.org" target="_blank">themes.svn.wordpress.org</a>
"remove_filter( 'the_content', 'wpautop' )" brings up 5 results.<br>
<br>
I haven't really looked closely to see what all the repercussions
of doing it would be, but at a glance I am not seeing it as being
wrong given what the theme is trying to do. For example, PageLines
is simply moving the two functions to a different priority
sequence (from the default 10 to 12) to "Prevent AUTOP inside of
shortcodes"<br>
<br>
... and the Tenacity theme appears to be removing these formatting
functions in favor of their own. <br>
<br>
Perhaps there is a better method? I'm sure this could be opened
for discussion but as I see from these recent examples, it appears
(at least with these two randomly picked from the search results)
to be done in a conscientious manner.<br>
<br>
<br clear="all">
Cais.<br>
<br>
<br>
<div class="gmail_quote">On Wed, Sep 5, 2012 at 8:50 PM, Japheth
Thomson <span dir="ltr"><<a href="mailto:japh@envato.com" target="_blank">japh@envato.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Yeah, it seems strange. There's a tutorial here: <a href="http://tutorials.mysitemyway.com/adding-column-layout-shortcodes-to-a-wordpress-theme/#highlighter_671922" target="_blank">http://tutorials.mysitemyway.com/adding-column-layout-shortcodes-to-a-wordpress-theme/#highlighter_671922</a>
which seems to claim that the <p></p> and <br
/> tags mess with column shortcodes, or something like
that?
<div>
<div>
<div>
<br>
<br>
<div class="gmail_quote">On 6 September 2012 10:47,
Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> I can't
really think of a reason a theme should be doing
either of those things at all. There might be
some legitimate uses (from a theme perspective)
but none come to mind at the moment.
<div>
<div><br>
<br>
<div>On 9/5/2012 7:27 PM, Japheth Thomson
wrote:<br>
</div>
</div>
</div>
<blockquote type="cite">
<div>
<div>
<div>Hello,</div>
<div><br>
</div>
<div>There's been some discussion today on
Twitter, and a blog post I wrote ( <a href="http://japh.co/NSXyTr" target="_blank">http://japh.co/NSXyTr</a>
), about themes that run code like:</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">remove_filter(
'the_content', 'wpautop' );</blockquote>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">remove_filter(
'the_content', 'wptexturize' );</blockquote>
<div><br>
</div>
<div>And also implementing a [raw][/raw]
shortcode like <a href="http://wordpress.org/support/topic/plugin-remove-wpautop-wptexturize-with-a-shortcode" target="_blank">http://wordpress.org/support/topic/plugin-remove-wpautop-wptexturize-with-a-shortcode</a></div>
<div><br>
</div>
<div>Could we add checks for these things
into Theme-Check? And would it be sensible
to do so?</div>
<div><br>
</div>
<div>Cheers,</div>
<div>Japh</div>
<div><br>
</div>
-- <br>
Japh Thomson<br>
WordPress Evangelist<br>
<a href="mailto:japh@envato.com" target="_blank">japh@envato.com</a><br>
<a href="http://envato.com" target="_blank">http://envato.com</a>
<div><a href="http://twitter.com/envato" target="_blank">http://twitter.com/envato</a><br>
<br>
</div>
<br>
<br>
<fieldset></fieldset>
<br>
</div>
</div>
<pre>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
<br>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
Japh Thomson<br>
WordPress Evangelist<br>
<a href="mailto:japh@envato.com" target="_blank">japh@envato.com</a><br>
<a href="http://envato.com" target="_blank">http://envato.com</a>
<div>
<a href="http://twitter.com/envato" target="_blank">http://twitter.com/envato</a><br>
<br>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
theme-reviewers mailing list
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Japh Thomson<br>WordPress Evangelist<br><a href="mailto:japh@envato.com" target="_blank">japh@envato.com</a><br><a href="http://envato.com" target="_blank">http://envato.com</a><div>
<a href="http://twitter.com/envato" target="_blank">http://twitter.com/envato</a><br><br></div><br>
</div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>