[theme-reviewers] quick help testing a theme

Kirk Wight kwight at kwight.ca
Mon Jan 23 14:19:59 UTC 2012


Done. Thanks for everyone's help.

On 23 January 2012 07:17, Edward Caissie <edward.caissie at gmail.com> wrote:

> I'm glad you were able to sort out where the errors were on the "live"
> install as I agree with Mike on this ...
> ... if PHP errors are found, especially if you are able to discern the
> code that is throwing them, then the ticket should be resolved as
> "not-approved". This is one of the primary guidelines.
>
> If this situation arises again, simply point out the code snippet(s) to
> the theme author and provide suggestions how they can: 1) fix the code;
> and, 2) locate their error logs that may show them the proof from their
> test installation.
>
>
> Cais.
>
>
>
> On Mon, Jan 23, 2012 at 3:36 AM, George Mamadashvili <
> georgemamadashvili at gmail.com> wrote:
>
>> Is  PKCS #7 <http://en.wikipedia.org/wiki/Cryptographic_Message_Syntax> required
>> to display PayPal donation link?
>>
>>
>> On Mon, Jan 23, 2012 at 2:26 AM, Kirk Wight <kwight at kwight.ca> wrote:
>>
>>> Aha, I did find them in the error log - I was looking in the wrong log
>>> before, which explains my confusion. So we can presume the submitter's
>>> environments have settings overriding the WP_DEBUG notices.
>>>
>>>  Thanks!
>>>
>>>
>>>
>>> On 22 January 2012 17:15, Michael Fields <michael at mfields.org> wrote:
>>>
>>>> Kirk,
>>>>
>>>>  I've never come across a situation like this. If the errors are not
>>>>> always replicable, would we give the submitter the benefit of the doubt and
>>>>> approve the theme? Or maybe require some sort of YMMV notice? Frankly, I
>>>>> want to simply require the changes that I know will fix it for our
>>>>> localhost situation, but that seems weird to insist a submitter change code
>>>>> for errors that can't always be reproduced.
>>>>>
>>>> Both of our local installations should take precedence over the live
>>>> server IMHO. If the theme is throwing notices and errors like this, it is
>>>> grounds for a failure as far as I know. php.ini can be configured to log
>>>> errors instead of displaying them inline. Have you checked the error logs
>>>> on your live server like Simon suggested?
>>>>
>>>> - Mike
>>>>
>>>> ______________________________**_________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>>>> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>>>>
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120123/442cbee6/attachment.htm>


More information about the theme-reviewers mailing list