Done. Thanks for everyone's help.<br><br><div class="gmail_quote">On 23 January 2012 07:17, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I'm glad you were able to sort out where the errors were on the "live" install as I agree with Mike on this ...<br>
... if PHP errors are found, especially if you are able to discern the code that is throwing them, then the ticket should be resolved as "not-approved". This is one of the primary guidelines.<br>
<br>If this situation arises again, simply point out the code snippet(s) to the theme author and provide suggestions how they can: 1) fix the code; and, 2) locate their error logs that may show them the proof from their test installation.<br>
<br><br clear="all">Cais.<div class="HOEnZb"><div class="h5"><br>
<br><br><div class="gmail_quote">On Mon, Jan 23, 2012 at 3:36 AM, George Mamadashvili <span dir="ltr"><<a href="mailto:georgemamadashvili@gmail.com" target="_blank">georgemamadashvili@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Is
<a href="http://en.wikipedia.org/wiki/Cryptographic_Message_Syntax" title="Cryptographic Message Syntax" style="text-decoration:none;color:rgb(11,0,128);background-image:none;background-color:rgb(242,242,242);font-family:sans-serif;font-size:13px;font-weight:bold;line-height:19px;text-align:center" target="_blank">PKCS #7</a> required to display PayPal donation link?<div>
<div><br>
<br><div class="gmail_quote">On Mon, Jan 23, 2012 at 2:26 AM, Kirk Wight <span dir="ltr"><<a href="mailto:kwight@kwight.ca" target="_blank">kwight@kwight.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Aha, I did find them in the error log - I was looking in the wrong log before, which explains my confusion. So we can presume the submitter's environments have settings overriding the WP_DEBUG notices.<div><br></div>
<div>
Thanks!<div><div><br><div><br></div><div><br><div class="gmail_quote">On 22 January 2012 17:15, Michael Fields <span dir="ltr"><<a href="mailto:michael@mfields.org" target="_blank">michael@mfields.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Kirk,<div><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I've never come across a situation like this. If the errors are not always replicable, would we give the submitter the benefit of the doubt and approve the theme? Or maybe require some sort of YMMV notice? Frankly, I want to simply require the changes that I know will fix it for our localhost situation, but that seems weird to insist a submitter change code for errors that can't always be reproduced.<br>
</blockquote></div>
Both of our local installations should take precedence over the live server IMHO. If the theme is throwing notices and errors like this, it is grounds for a failure as far as I know. php.ini can be configured to log errors instead of displaying them inline. Have you checked the error logs on your live server like Simon suggested?<br>
<br>
- Mike<div><div><br>
______________________________<u></u>_________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a><br>
</div></div></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>