[theme-reviewers] quick help testing a theme

[Kirk Wight]

Simon - WP_DEBUG true, php.ini set to log errors, and no PHP-related errors
present in the log.

Mike - Exactly what I get on localhost, and those errors do make sense
according to what I've discovered in the code - yet on my hosting account,
the settings gets saved fine with no errors, and work as expected.

I've never come across a situation like this. If the errors are not always
replicable, would we give the submitter the benefit of the doubt and
approve the theme? Or maybe require some sort of YMMV notice? Frankly, I
want to simply require the changes that I know will fix it for our
localhost situation, but that seems weird to insist a submitter change code
for errors that can't always be reproduced.

Any suggestions?



On 22 January 2012 16:50, Michael Fields <michaelfields at automattic.com>wrote:

> Hi!
>
> I received no errors when I installed this theme on localhost with
> WP_DEBUG defined as true.
>
> Once I navigated to Appearance -> Mantra Settings (better stated as "Theme
> Options") and clicked the "Save Settings" button without making any
> changes, I got 3 notices and a warning:
>
> ( ! ) Notice: Undefined index: mantra_facebook in
> /Users/me/Sites/wp-content/**themes/mantra/admin/mantra-**admin-functions.php
> on line 1374
> Call Stack
> #    Time    Memory    Function    Location
> 1    0.0009    426372    {main}( )    ../options.php:0
> 2    0.2720    19835680    update_option( )    ../options.php:149
> 3    0.2720    19835728    sanitize_option( )    ../option.php:227
> 4    0.2720    19835792    apply_filters( )    ../formatting.php:2627
> 5    0.2721    19836664    call_user_func_array ( )    ../plugin.php:170
> 6    0.2721    19836680    ma_options_validate( )    ../plugin.php:170
>
> ( ! ) Notice: Undefined index: mantra_tweeter in
> /Users/me/Sites/wp-content/**themes/mantra/admin/mantra-**admin-functions.php
> on line 1375
> Call Stack
> #    Time    Memory    Function    Location
> 1    0.0009    426372    {main}( )    ../options.php:0
> 2    0.2720    19835680    update_option( )    ../options.php:149
> 3    0.2720    19835728    sanitize_option( )    ../option.php:227
> 4    0.2720    19835792    apply_filters( )    ../formatting.php:2627
> 5    0.2721    19836664    call_user_func_array ( )    ../plugin.php:170
> 6    0.2721    19836680    ma_options_validate( )    ../plugin.php:170
>
> ( ! ) Notice: Undefined index: mantra_rss in /Users/me/Sites/wp-content/**
> themes/mantra/admin/mantra-**admin-functions.php on line 1376
> Call Stack
> #    Time    Memory    Function    Location
> 1    0.0009    426372    {main}( )    ../options.php:0
> 2    0.2720    19835680    update_option( )    ../options.php:149
> 3    0.2720    19835728    sanitize_option( )    ../option.php:227
> 4    0.2720    19835792    apply_filters( )    ../formatting.php:2627
> 5    0.2721    19836664    call_user_func_array ( )    ../plugin.php:170
> 6    0.2721    19836680    ma_options_validate( )    ../plugin.php:170
>
> ( ! ) Warning: Cannot modify header information - headers already sent by
> (output started at /Users/me/Sites/wp-content/**
> themes/mantra/admin/mantra-**custom-styles.php:123) in
> /Users/me/Sites/trunk/wp-**includes/pluggable.php on line 866
> Call Stack
> #    Time    Memory    Function    Location
> 1    0.0009    426372    {main}( )    ../options.php:0
> 2    0.2959    19868080    wp_redirect( )    ../options.php:165
> 3    0.2960    19873744    header ( )    ../pluggable.php:866
>
> Also, when I switch from Mantra to a new theme, I get the following:
>
> Warning: Cannot modify header information - headers already sent by
> (output started at /Users/me/Sites/wp-content/**
> themes/mantra/admin/mantra-**custom-styles.php:123) in
> /Users/me/Sites/trunk/wp-**includes/pluggable.php on line 866
>
> Hope this helps,
> -Mike
>
> ______________________________**_________________
> theme-reviewers mailing list
> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120122/06c311e1/attachment.htm>