[theme-reviewers] Using WordPress core functions vs. custom functions

Chip Bennett chip at chipbennett.net
Wed Feb 22 20:49:42 UTC 2012


IIRC, the issue on this one was a question of functionality over and above
core functionality, especially with respect to the custom background. I
could very well be wrong, though...

Chip

On Wed, Feb 22, 2012 at 2:40 PM, Edward Caissie <edward.caissie at gmail.com>wrote:

> I haven't looked deep into the code, but if you believe the functionality
> being offered by the theme goes above and beyond the standard
> implementation recommended to be used in the guidelines then it can be
> noted but I do not believe it would push the theme over to a "not-approved"
> resolution ...
>
> ... I'll see if I can find some time to look into the code myself as well.
>
>
> Cais.
>
>
> On Wed, Feb 22, 2012 at 12:55 PM, Caroline Moore <calobee at gmail.com>wrote:
>
>> Hi all,
>>
>> I'm working on the PageLines review.  The theme uses custom functions to
>> add headers and custom backgrounds (instead of add_custom_image_header or
>> add_custom_background).
>>
>> I'm assuming this is OK since this theme is kind of a special case.  I
>> can see where, in the interests of keeping all the theme's options in one
>> place, it makes more sense to use custom functions. It also looks as though
>> the functionality offered is more complex than the WordPress defaults.
>>
>> Let me know if I'm not on the right track with that thinking.
>>
>> Thanks!
>> Caro
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120222/d8969a5b/attachment-0001.htm>


More information about the theme-reviewers mailing list