[theme-reviewers] About Text Domain Issues

[Qamar Ashraf]

Thanks Chip

On Sat, Feb 11, 2012 at 7:41 PM, Chip Bennett <chip at chipbennett.net> wrote:

> If it's in the Theme, then the Theme needs to provide the translation for
> the string. It doesn't matter if that same string is in core. We've covered
> this one quite a bit on the list.
>
> That said: it is a minor enough issue that I would approve the Theme, with
> the textdomain being a *required* fix for the next Theme update.
>
> Chip
>
>
> On Sat, Feb 11, 2012 at 8:18 AM, Qamar Ashraf <life.object at gmail.com>wrote:
>
>> Hello George,
>> Yes you are right. But author has given comments about his discussion
>> related to text domain which is,
>>
>> - The texts in the file abc.php that are inherited from WP are not
>> translated using the theme's translation context. Rather WP's native
>> translation is used. This is deliberate as per the discussion on this
>> thread:
>> http://lists.wordpress.org/pipermail/theme-reviewers/2011-December/007526.html
>> .
>>
>> Take Care
>>
>>
>> On Sat, Feb 11, 2012 at 7:07 PM, George Mamadashvili <
>> georgemamadashvili at gmail.com> wrote:
>>
>>> Not sure if this can be only reason to not approve theme, but Theme
>>> Review codex says, that themes are required to use  theme-slug as
>>> textdomain for translation.
>>>
>>>
>>> On Sat, Feb 11, 2012 at 4:25 PM, Qamar Ashraf <life.object at gmail.com>wrote:
>>>
>>>> Thanks Caroline
>>>>
>>>>
>>>> On Sat, Feb 11, 2012 at 5:21 PM, Caroline Moore <calobee at gmail.com>wrote:
>>>>
>>>>> If there are only one or two small issues, I usually approve but make
>>>>> a note of them, and ask that they be fixed in the next release. Others have
>>>>> done this when reviewing my themes too.
>>>>>
>>>>> Sent from my iPhone
>>>>>
>>>>> On Feb 11, 2012, at 7:16 AM, Qamar Ashraf <life.object at gmail.com>
>>>>> wrote:
>>>>>
>>>>> Hello,
>>>>> I am currently reviewing a theme so want to clarify my concept before
>>>>> marking it "approved". Theme Check plugin has given recommendations to fix
>>>>> some text domain issues. So can i approve a theme with the recommended text
>>>>> domain issues.
>>>>>
>>>>> Example is:
>>>>>
>>>>> RECOMMENDED: Text domain problems in *abc.php*. You have not included
>>>>> a text domain!
>>>>> Line 91: $title = sprintf( __('%s (Pending)'), $item->title );
>>>>>
>>>>> Take Care
>>>>>
>>>>> --
>>>>> Regards
>>>>> Qamar Ashraf
>>>>> Project Manager
>>>>> www.tutorialchip.com
>>>>> www.freestockphotosclub.com
>>>>> www.twunfollowapp.com
>>>>> @lifeobject1
>>>>>
>>>>>  _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Regards
>>>> Qamar Ashraf
>>>> Project Manager
>>>> www.tutorialchip.com
>>>> www.freestockphotosclub.com
>>>> www.twunfollowapp.com
>>>> @lifeobject1
>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>>
>> --
>> Regards
>> Qamar Ashraf
>> Project Manager
>> www.tutorialchip.com
>> www.freestockphotosclub.com
>> www.twunfollowapp.com
>> @lifeobject1
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>


-- 
Regards
Qamar Ashraf
Project Manager
www.tutorialchip.com
www.freestockphotosclub.com
www.twunfollowapp.com
@lifeobject1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120211/6eaf3f1f/attachment-0001.htm>