Thanks Chip<br><br><div class="gmail_quote">On Sat, Feb 11, 2012 at 7:41 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
If it's in the Theme, then the Theme needs to provide the translation for the string. It doesn't matter if that same string is in core. We've covered this one quite a bit on the list.<div><br></div><div>That said: it is a minor enough issue that I would approve the Theme, with the textdomain being a *required* fix for the next Theme update.</div>
<span class="HOEnZb"><font color="#888888">
<div><br></div></font></span><div><span class="HOEnZb"><font color="#888888">Chip</font></span><div><div class="h5"><br><br><div class="gmail_quote">On Sat, Feb 11, 2012 at 8:18 AM, Qamar Ashraf <span dir="ltr"><<a href="mailto:life.object@gmail.com" target="_blank">life.object@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello George,<div>Yes you are right. But author has given comments about his discussion related to text domain which is,</div><div><br></div><div>- The texts in the file abc.php that are inherited from WP are not translated using the theme's translation context. Rather WP's native translation is used. This is deliberate as per the discussion on this thread: <a href="http://lists.wordpress.org/pipermail/theme-reviewers/2011-December/007526.html" target="_blank">http://lists.wordpress.org/pipermail/theme-reviewers/2011-December/007526.html</a>.</div>
<div><br></div><div>Take Care<div><div><br><br><div class="gmail_quote">On Sat, Feb 11, 2012 at 7:07 PM, George Mamadashvili <span dir="ltr"><<a href="mailto:georgemamadashvili@gmail.com" target="_blank">georgemamadashvili@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Not sure if this can be only reason to not approve theme, but Theme Review codex says, that themes are required to use
<tt style="line-height:22px;text-align:left;font-size:12px">theme-slug</tt><span style="line-height:22px;text-align:left;font-size:12px;font-family:'Lucida Grande',Verdana,'Bitstream Vera Sans',Arial,sans-serif"> as textdomain for translation.</span><div>
<div><br>
<br><div class="gmail_quote">On Sat, Feb 11, 2012 at 4:25 PM, Qamar Ashraf <span dir="ltr"><<a href="mailto:life.object@gmail.com" target="_blank">life.object@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks Caroline<div><div><br><br><div class="gmail_quote">On Sat, Feb 11, 2012 at 5:21 PM, Caroline Moore <span dir="ltr"><<a href="mailto:calobee@gmail.com" target="_blank">calobee@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF"><div>If there are only one or two small issues, I usually approve but make a note of them, and ask that they be fixed in the next release. Others have done this when reviewing my themes too.<br><br>
Sent from my iPhone</div><div><div><div><br>On Feb 11, 2012, at 7:16 AM, Qamar Ashraf <<a href="mailto:life.object@gmail.com" target="_blank">life.object@gmail.com</a>> wrote:<br><br></div><div></div><blockquote type="cite">
<div>Hello,<div>I am currently reviewing a theme so want to clarify my concept before marking it "approved". Theme Check plugin has given recommendations to fix some text domain issues. So can i approve a theme with the recommended text domain issues.</div>
<div><br></div><div>Example is:</div><div><br></div><div><span>RECOMMENDED</span>: Text domain problems in <strong>abc.php</strong>. You have not included a text domain!</div><div>Line 91: $title = sprintf( __('%s (Pending)'), $item->title );</div>
<div><br></div><div>Take Care</div><div><div><br></div>-- <br><font color="#666666">Regards</font><div><font color="#666666">Qamar Ashraf</font></div><div><font color="#666666">Project Manager</font></div><div><font color="#666666"><a href="http://www.tutorialchip.com" target="_blank">www.tutorialchip.com</a></font></div>
<div><font color="#666666"><a href="http://www.freestockphotosclub.com" target="_blank">www.freestockphotosclub.com</a></font></div><div><a href="http://www.twunfollowapp.com" target="_blank">www.twunfollowapp.com</a></div>
<div><font color="#666666">@lifeobject1</font></div><br>
</div>
</div></blockquote></div></div><blockquote type="cite"><div><span>_______________________________________________</span><br><span>theme-reviewers mailing list</span><br><span><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a></span><br>
<span><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></span><br></div></blockquote></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><font color="#666666">Regards</font><div><font color="#666666">Qamar Ashraf</font></div><div><font color="#666666">Project Manager</font></div><div><font color="#666666"><a href="http://www.tutorialchip.com" target="_blank">www.tutorialchip.com</a></font></div>
<div><font color="#666666"><a href="http://www.freestockphotosclub.com" target="_blank">www.freestockphotosclub.com</a></font></div><div><a href="http://www.twunfollowapp.com" target="_blank">www.twunfollowapp.com</a></div>
<div><font color="#666666">@lifeobject1</font></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><font color="#666666">Regards</font><div><font color="#666666">Qamar Ashraf</font></div><div><font color="#666666">Project Manager</font></div><div><font color="#666666"><a href="http://www.tutorialchip.com" target="_blank">www.tutorialchip.com</a></font></div>
<div><font color="#666666"><a href="http://www.freestockphotosclub.com" target="_blank">www.freestockphotosclub.com</a></font></div><div><a href="http://www.twunfollowapp.com" target="_blank">www.twunfollowapp.com</a></div>
<div><font color="#666666">@lifeobject1</font></div><br>
</div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><font color="#666666">Regards</font><div><font color="#666666">Qamar Ashraf</font></div><div><font color="#666666">Project Manager</font></div><div><font color="#666666"><a href="http://www.tutorialchip.com" target="_blank">www.tutorialchip.com</a></font></div>
<div><font color="#666666"><a href="http://www.freestockphotosclub.com" target="_blank">www.freestockphotosclub.com</a></font></div><div><a href="http://www.twunfollowapp.com" target="_blank">www.twunfollowapp.com</a></div>
<div><font color="#666666">@lifeobject1</font></div><br>