[theme-reviewers] [WordPress Themes] #7174: THEME: zBench - 1.3.5
zwwooooo
zwwooooo at gmail.com
Sat Apr 7 07:56:23 UTC 2012
Hi, I had add filter in my theme and test. Normal work. But I don't know
that this method correctly or not. code:
*functions.php*:
function custom_wp_title($title) {
global $page, $paged;
$title .= get_bloginfo( 'name' );
$site_description = get_bloginfo( 'description', 'display' );
if ( $site_description && ( is_home() || is_front_page() ) )
$title .= " | $site_description";
if ( $paged >= 2 || $page >= 2 )
$title .= ' | ' . sprintf( __( 'Page %s', 'zbench' ), max( $paged,
$page ) );
return $title;
}
add_filter( 'wp_title', 'custom_wp_title' );
*header.php*:
<title><?php wp_title( '|', true, 'right' ); ?></title>
在 2012年4月7日 下午3:40，Konstantin Obenland <obenland at gmx.de>写道：
> I'm glad you did answer it here, gives me the chance to ask: So what does
> that mean exactly? :)
>
> Are the requirements specified in this post not real requirements, and
> we're not supposed to enforce them?
>
> The very first sentence of the post says:
> "[...] and will be made effective one month following release [of
> WordPress 3.3]"
>
> As I'm still pretty green as a reviewer, and in the beginning I found it
> confusing that I had to look all over the place to make sure I have all
> requirements in check, when reviewing. I still have like four reference
> tabs open when I review a Theme:
>
> Theme Review Codex
> Theme Unit Test Codex
> The above mentioned post
> Chips article for new reviewers on his blog
>
> This is what I base my reviews on but I can't be sure that I didn't miss a
> requirement hidden somewhere else. :)
>
> If there is no reason not to have the requirements from the post in the
> Theme Review Codex, I'd be happy to help migrating them there!
>
> Thanks,
> Konstantin
>
> Sent from my iPad
>
> On 07.04.2012, at 07:39, Emil Uzelac <emil at themeid.com> wrote:
>
> I should not answer this here, but since it's addressed to all :)
>
> See:
> http://make.wordpress.org/themes/2011/11/10/wordpress-3-3-proposed-guidelines-revisions/and as far as I know that's not yet in
> http://codex.wordpress.org/Theme_Review also see:
> http://hitchhackerguide.com/2011/02/12/wp_title/
>
> Emil
>
> On Sat, Apr 7, 2012 at 12:28 AM, zwwooooo <zwwooooo at gmail.com> wrote:
>
>> Thanks. I have a question of this REQUIRED:
>>
>>
>> REQUIRED: Themes are REQUIRED to use 'wp_title' filter, to filter
>>> wp_title() (RECOMMENDED), or pass argument to wp_title() (OPTIONALLY),
>>> in order to modify document title content
>>>
>>
>> I found that most of the theme's method from Twenty Eleven or Twenty Ten.
>> This REQUIRED is new required? Have specific example? My English is poor.
>> Difficult to search and read the related content.
>>
>> 在 2012年4月7日 下午12:47，Emil Uzelac <emil at themeid.com>写道：
>>
>> it's live now
>>>
>>> On Fri, Apr 6, 2012 at 11:41 PM, zwwooooo <zwwooooo at gmail.com> wrote:
>>>
>>>> Hello,
>>>>
>>>> Theme zBench has been through the review a week. Any help make it live?
>>>> Thanks.
>>>>
>>>> 在 2012年3月31日 下午11:53，WordPress Themes <
>>>> theme-reviewers at lists.wordpress.org>写道：
>>>>
>>>>> #7174: THEME: zBench - 1.3.5
>>>>> -------------------------+------------------------
>>>>> Reporter: zwwooooo | Owner: kobenland
>>>>> Type: theme | Status: closed
>>>>> Priority: major | Resolution: approved
>>>>> Keywords: theme-zbench |
>>>>> -------------------------+------------------------
>>>>> Changes (by kobenland):
>>>>>
>>>>> * status: assigned => closed
>>>>> * resolution: => approved
>>>>>
>>>>>
>>>>> Comment:
>>>>>
>>>>> = Review Summary =
>>>>>
>>>>> === Please fix in next submission: ===
>>>>>
>>>>> * REQUIRED: Themes are REQUIRED to use `'wp_title'` filter, to filter
>>>>> `wp_title()` (RECOMMENDED), or pass argument to `wp_title()`
>>>>> (OPTIONALLY),
>>>>> in order to modify document title content
>>>>>
>>>>> * REQUIRED: Themes are REQUIRED to enqueue comment-reply script via
>>>>> callback, rather than hard-code the enqueue in the HTML document head.
>>>>> Example:
>>>>> {{{
>>>>> #!php
>>>>> <?php
>>>>> function oenology_enqueue_comment_reply() {
>>>>> if ( is_singular() && comments_open() && get_option(
>>>>> 'thread_comments' ) ) {
>>>>> wp_enqueue_script( 'comment-reply' );
>>>>> }
>>>>> }
>>>>> add_action( 'wp_enqueue_scripts', 'oenology_enqueue_comment_reply' );
>>>>> }}}
>>>>>
>>>>> * REQUIRED: Please make "Powered by..." message translatable
>>>>>
>>>>> [[BR]]
>>>>>
>>>>> * Previous version of Theme APPROVED
>>>>> * No previous-ticket ''required'' issues
>>>>> * Diff-review only
>>>>> * Ticket being resolved as '''APPROVED'''
>>>>>
>>>>> --
>>>>> Ticket URL: <http://themes.trac.wordpress.org/ticket/7174#comment:2>
>>>>> WordPress Themes <http://themes.trac.wordpress.org/>
>>>>> WordPress.org Theme Directory Reviews
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Greets,
>>>> zwwooooo
>>>> http://zww.me
>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>>
>> --
>> Greets,
>> zwwooooo
>> http://zww.me
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
--
Greets,
zwwooooo
http://zww.me
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120407/bf9f018f/attachment.htm>
More information about the theme-reviewers
mailing list