Hi, I had add filter in my theme and test. Normal work. But I don't know that this method correctly or not. code:<br><br><b>functions.php</b>:<br><br>function custom_wp_title($title) {<br> global $page, $paged;<br> $title .= get_bloginfo( 'name' );<br>
$site_description = get_bloginfo( 'description', 'display' );<br> if ( $site_description && ( is_home() || is_front_page() ) )<br> $title .= " | $site_description";<br> if ( $paged >= 2 || $page >= 2 )<br>
$title .= ' | ' . sprintf( __( 'Page %s', 'zbench' ), max( $paged, $page ) );<br> return $title;<br>}<br>add_filter( 'wp_title', 'custom_wp_title' );<br><br><b>header.php</b>:<br>
<br><title><?php wp_title( '|', true, 'right' ); ?></title><br><br><br><div class="gmail_quote">在 2012年4月7日 下午3:40，Konstantin Obenland <span dir="ltr"><<a href="mailto:obenland@gmx.de">obenland@gmx.de</a>></span>写道：<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF"><div>I'm glad you did answer it here, gives me the chance to ask: So what does that mean exactly? :)</div>
<div><br></div><div>Are the requirements specified in this post not real requirements, and we're not supposed to enforce them? </div><div><br></div><div>The very first sentence of the post says:</div><div>"[...] and will be made effective one month following release [of WordPress 3.3]"</div>
<div><br></div><div>As I'm still pretty green as a reviewer, and in the beginning I found it confusing that I had to look all over the place to make sure I have all requirements in check, when reviewing. I still have like four reference tabs open when I review a Theme:</div>
<div><br></div><div>Theme Review Codex</div><div>Theme Unit Test Codex</div><div>The above mentioned post</div><div>Chips article for new reviewers on his blog</div><div><br></div><div>This is what I base my reviews on but I can't be sure that I didn't miss a requirement hidden somewhere else. :)</div>
<div><br></div><div>If there is no reason not to have the requirements from the post in the Theme Review Codex, I'd be happy to help migrating them there!</div><div><br></div><div>Thanks,</div><div>Konstantin<br><br>Sent from my iPad</div>
<div><div></div><div class="h5"><div><br>On 07.04.2012, at 07:39, Emil Uzelac <<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">I should not answer this here, but since it's addressed to all :)</font></font></font><div>
<font color="#333333"><font><font face="arial,helvetica,sans-serif"><br>
</font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">See: <a href="http://make.wordpress.org/themes/2011/11/10/wordpress-3-3-proposed-guidelines-revisions/" target="_blank">http://make.wordpress.org/themes/2011/11/10/wordpress-3-3-proposed-guidelines-revisions/</a> and as far as I know that's not yet in <a href="http://codex.wordpress.org/Theme_Review" target="_blank">http://codex.wordpress.org/Theme_Review</a> also see: <a href="http://hitchhackerguide.com/2011/02/12/wp_title/" target="_blank">http://hitchhackerguide.com/2011/02/12/wp_title/</a></font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">Emil<br></font></font></font><br><div class="gmail_quote">
On Sat, Apr 7, 2012 at 12:28 AM, zwwooooo <span dir="ltr"><<a href="mailto:zwwooooo@gmail.com" target="_blank">zwwooooo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks. I have a question of this REQUIRED:<div><br><br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">REQUIRED: Themes are REQUIRED to use <tt>'wp_title'</tt> filter, to filter <tt>wp_title()</tt> (RECOMMENDED), or pass argument to <tt>wp_title()</tt> (OPTIONALLY), in order to modify document title content
<br></blockquote><br></div><div class="gmail_quote">I found that most of the theme's method from Twenty Eleven or Twenty Ten. This REQUIRED is new required? Have specific example? My English is poor. Difficult to search and read the related content.<br>
<br>在 2012年4月7日 下午12:47，Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span>写道：<div><div><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<font color="#333333"><font><font face="arial,helvetica,sans-serif">it's live now<br></font></font></font><br><div class="gmail_quote"><div><div></div><div>On Fri, Apr 6, 2012 at 11:41 PM, zwwooooo <span dir="ltr"><<a href="mailto:zwwooooo@gmail.com" target="_blank">zwwooooo@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div></div><div>Hello,<br><br>Theme zBench has been through the review a week. Any help make it live? Thanks.<br>
<br><div class="gmail_quote">
在 2012年3月31日 下午11:53，WordPress Themes <span dir="ltr"><<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>></span>写道：<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>#7174: THEME: zBench - 1.3.5<br>
-------------------------+------------------------<br>
Reporter: zwwooooo | Owner: kobenland<br>
</div> Type: theme | Status: closed<br>
Priority: major | Resolution: approved<br>
<div>Keywords: theme-zbench |<br>
-------------------------+------------------------<br>
Changes (by kobenland):<br>
<br>
</div> * status: assigned => closed<br>
* resolution: => approved<br>
<br>
<br>
Comment:<br>
<br>
= Review Summary =<br>
<br>
=== Please fix in next submission: ===<br>
<br>
* REQUIRED: Themes are REQUIRED to use `'wp_title'` filter, to filter<br>
`wp_title()` (RECOMMENDED), or pass argument to `wp_title()` (OPTIONALLY),<br>
in order to modify document title content<br>
<br>
* REQUIRED: Themes are REQUIRED to enqueue comment-reply script via<br>
callback, rather than hard-code the enqueue in the HTML document head.<br>
Example:<br>
{{{<br>
#!php<br>
<?php<br>
function oenology_enqueue_comment_reply() {<br>
if ( is_singular() && comments_open() && get_option(<br>
'thread_comments' ) ) {<br>
wp_enqueue_script( 'comment-reply' );<br>
}<br>
}<br>
add_action( 'wp_enqueue_scripts', 'oenology_enqueue_comment_reply' );<br>
}}}<br>
<br>
* REQUIRED: Please make "Powered by..." message translatable<br>
<br>
[[BR]]<br>
<br>
* Previous version of Theme APPROVED<br>
* No previous-ticket ''required'' issues<br>
* Diff-review only<br>
* Ticket being resolved as '''APPROVED'''<span><font color="#888888"><br>
<font color="#888888"><br>
--<br>
Ticket URL: <<a href="http://themes.trac.wordpress.org/ticket/7174#comment:2" target="_blank">http://themes.trac.wordpress.org/ticket/7174#comment:2</a>><br>
</font><div><div></div><div>WordPress Themes <<a href="http://themes.trac.wordpress.org/" target="_blank">http://themes.trac.wordpress.org/</a>><br>
<a href="http://WordPress.org" target="_blank">WordPress.org</a> Theme Directory Reviews<br>
</div></div></font></span></blockquote></div><span><font color="#888888"><br><br clear="all"><br>-- <br>Greets,<br>zwwooooo<br><a href="http://zww.me" target="_blank">http://zww.me</a><div></div><br>
</font></span><br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div></div></div><div><div><br><br clear="all"><br>-- <br>Greets,<br>zwwooooo<br><a href="http://zww.me" target="_blank">http://zww.me</a><div></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>theme-reviewers mailing list</span><br><span><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a></span><br>
<span><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></span><br></div></blockquote></div></div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Greets,<br>zwwooooo<br><a href="http://zww.me" target="_blank">http://zww.me</a><div></div><br>