[theme-reviewers] Question on Custom Headers
Sayontan Sinha
sayontan at gmail.com
Wed Sep 7 21:56:12 UTC 2011
Hi,
One of the comments on the last submission of my theme was that I should be
using add_custom_image_header() if I am providing Custom Header
functionality. So I started coding this into my theme. While doing so I
noticed that the Header admin page has some text that is printed:
You can upload a custom header image to be shown at the top of your site
> instead of the default one. On the next screen you will be able to crop the
> image.
> Images of exactly *1000 × 55 pixels* will be used as-is.
>
The part that says 1000 x 55 comes from the defined values of
HEADER_IMAGE_WIDTH and HEADER_IMAGE_HEIGHT. Now, while these functions can
be filtered, they don't respond to fluid widths. Also, a sentence such as
"Images of exactly 100% x 55 pixels will be used as-is" doesn't make sense.
This makes it a problem for fluid width layouts. While I am not concerned
about the actual generation of the CSS (since that is in my hands), the
above text can get misleading. On a related note, if you filter the
HEADER_IMAGE_WIDTH to make it pass a percentage, it trashes the "%".
Is there a way to change / hide this text, then? As per the code in the core
it is shown "if ( current_theme_supports( 'custom-header-uploads' ) )",
which is obviously true, and I couldn't find any filter to turn this off.
If anybody has other suggestions or if I have missed something please feel
free to respond.
Sayontan.
--
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Beating Australia in Cricket is like killing a celebrity. The death gets
more coverage than the crime.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110907/f23ef1ea/attachment.htm>
More information about the theme-reviewers
mailing list