[theme-reviewers] [WordPress Themes] #3787: THEME: Minimatica - 1.0

[Daniel Tara]

Interesting enough, embeds from wordpress.tv are not working for me either.
I just tried adding the same video here:
http://demo.onedesigns.com/minimatica/?p=21
That video was working when I was developing the theme, it's the same from
the Test Data.

Does anyone have an idea where this may be coming from?

Daniel

-----Original Message-----
From: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Tony
Jansen
Sent: Thursday, May 12, 2011 2:11 AM
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] [WordPress Themes] #3787: THEME: Minimatica -
1.0

Hi Pseudoxiah,

oEmbed is not working here:
http://review.umarov.nl/2008/06/03/post-format-test-video/, while it is
working on standard Twenty Ten on the same site. My comment that it is
"switched off" may have been too specific. No plugins running on that site
apart from debogger and theme-checker.

For the audio player:
I couldn't find a name/type in the license that refers to MIT or that i
could lead back to the list of GPL compatible licenses here:
http://www.gnu.org/licenses/license-list.html . As referenced to in the
guidelines here: http://codex.wordpress.org/Theme_Review .

For the fonts:
See the theme review link above under "GPL-Compatible Font Licenses". It
doesn't adhere to that list. 

The redirect is being discussed right now as you may have noticed :)

The Gallery mode is faltering on two requirements: proper display of sticky
posts and the comments disabled link. 
20/20 hindsight: i may leave such a recommendation about modes out in future
reviews. Please bear with me about that one, this was my 2nd review I did.

-Tony

-----Oorspronkelijk bericht-----
Van: WordPress Themes [mailto:theme-reviewers at lists.wordpress.org] 
Verzonden: donderdag 12 mei 2011 0:52
Aan: undisclosed-recipients:
Onderwerp: Re: [WordPress Themes] #3787: THEME: Minimatica - 1.0

#3787: THEME: Minimatica - 1.0
-------------------------+-----------------------------
  Reporter:  pseudoxiah  |     Owner:  tonyjansen_nl
      Type:  theme       |    Status:  assigned
Resolution:              |  Keywords:  theme-minimatica
-------------------------+-----------------------------

Comment (by pseudoxiah):

 Hi Tony,

 Thank you for the review.

 I would appreciate if you would look over these observations and of course
any other reviewer input is welcome:

 * oEMbed is working for me, here's a working example:
 http://demo.onedesigns.com/minimatica/?p=27
 What is the exact piece of code you consider is disabling oEmbed? Are you
sure this is not because of your installation or a plugin you have
installed?

 * The audio player is licensed under the MIT license, which is GPL
compatible. In the directory audio-player there is a file license.txt

 * The font Vegur is in the public domain. There is a  file in the fonts
folder that specifically mentions this. Here is the font's home page where
it is specified it is public domain:
 http://www.fontspace.com/arro/vegur

 * The custom preview was actually stolen from The Erudite theme which does
the same thing and is in the repository. However, if it is decided this is
not appropriate I will of course leave it default, no problem.

 * The gallery mode set by default is intentional, since this is a
photography theme. As well is leaving out sticky posts. This is all  handled
normally in blog mode and the user can choose the preferred mode.
 I can document these things, but I would not switch the default view mode,
since this was the theme's original intention.

 * I would also rather not display the "Comments are closed message"
 because I feel it's cutting on aesthetics, but if it's decided this is a
requirement it will be added.

--
Ticket URL: <http://themes.trac.wordpress.org/ticket/3787#comment:4>
WordPress Themes <http://themes.trac.wordpress.org/>
WordPress.org Theme Directory Reviews


_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers