[theme-reviewers] theme-reviewers Digest, Vol 12, Issue 33

Reuben rgunday at gmail.com
Wed May 11 22:23:58 UTC 2011 

Its bad to change core functionality by a theme.

The author can add a demo link instead of changing preview link.
Here's the code to do it

add_filter( 'theme_action_links', 'theme_demo_link', 10, 2 );
function theme_demo_link( $actions, $theme ) {
	if ( 'Twenty Ten' == $theme['Name'] ) {
		$actions[] = '| <a href="http://link-to-demo">Demo</a>';
	}

	return $actions;
}

On Thu, May 12, 2011 at 3:30 AM,
<theme-reviewers-request at lists.wordpress.org> wrote:
> Send theme-reviewers mailing list submissions to
>        theme-reviewers at lists.wordpress.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
>        http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> or, via email, send a message with subject or body 'help' to
>        theme-reviewers-request at lists.wordpress.org
>
> You can reach the person managing the list at
>        theme-reviewers-owner at lists.wordpress.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of theme-reviewers digest..."
>
>
> Today's Topics:
>
>   1. Cirumventing Theme Directory Preview in Ticket    #3787 (Tony Jansen)
>   2. Re: Cirumventing Theme Directory Preview in       Ticket #3787
>      (Jonny Cauvain)
>   3. Re: Cirumventing Theme Directory Preview in       Ticket #3787
>      (Emil Uzelac)
>   4. Re: Cirumventing Theme Directory Preview in       Ticket #3787
>      (Jonny Cauvain)
>   5. Re: Cirumventing Theme Directory Preview in       Ticket #3787
>      (Emil Uzelac)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Wed, 11 May 2011 23:40:55 +0200
> From: "Tony Jansen" <info at tonyjansen.nl>
> Subject: [theme-reviewers] Cirumventing Theme Directory Preview in
>        Ticket  #3787
> To: <theme-reviewers at lists.wordpress.org>
> Message-ID: <002f01cc1024$1bacfa90$5306efb0$@tonyjansen.nl>
> Content-Type: text/plain; charset="us-ascii"
>
> Hello all,
>
>
>
> Earlier today during a review I encountered the following code in
> functions.php:
>
> /**
>
> * The WordPress Theme Directory Preview may not be appropriate for this
> theme, so redirecting to custom preview
>
> */
>
> if( false !== strpos( site_url(), 'http://wp-themes.com'  )) {
>
>                wp_redirect( 'http://demo.onedesigns.com/minimatica/' );
>
>                exit();
>
> }
>
> which circumvents the regular theme preview to display something that may
> have nothing to do with the theme at all or worse (not the case in this
> case, mind you).
>
> I have halted the review after conferring with greuben, who noted that it
> was bad and unacceptable, and I recommended a not-approved.
>
> This technique may be old hat but I still like to know what you think about
> it, was I right to handle it this way?
>
>
>
>  <http://themes.trac.wordpress.org/ticket/3787#comment:3>
> http://themes.trac.wordpress.org/ticket/3787#comment:3
>
>
>
> Best Regards,
>
> Tony Jansen
>
>
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110511/c2d00cf1/attachment-0001.htm>
>
> ------------------------------
>
> Message: 2
> Date: Wed, 11 May 2011 22:51:00 +0100
> From: Jonny Cauvain <furcifer at furcifer.me>
> Subject: Re: [theme-reviewers] Cirumventing Theme Directory Preview in
>        Ticket #3787
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <BANLkTimaHP=8tTVA8FqGpsAXSb+gapphrQ at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> The author of that theme is one of our reviewers.  XD and i see no problem
> with that demo re-direct. But that's just my 2c
>
> On 11 May 2011 22:41, "Tony Jansen" <info at tonyjansen.nl> wrote:
>
> Hello all,
>
>
>
> Earlier today during a review I encountered the following code in
> functions.php:
>
> /**
>
> * The WordPress Theme Directory Preview may not be appropriate for this
> theme, so redirecting to custom preview
>
> */
>
> if( false !== strpos( site_url(), 'http://wp-themes.com'  )) {
>
>                wp_redirect( 'http://demo.onedesigns.com/minimatica/' );
>
>                exit();
>
> }
>
> which circumvents the regular theme preview to display something that may
> have nothing to do with the theme at all or worse (not the case in this
> case, mind you).
>
> I have halted the review after conferring with greuben, who noted that it
> was bad and unacceptable, and I recommended a not-approved.
>
> This technique may be old hat but I still like to know what you think about
> it, was I right to handle it this way?
>
>
>
> http://themes.trac.wordpress.org/ticket/3787#comment:3
>
>
>
> Best Regards,
>
> Tony Jansen
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110511/784d0d3e/attachment-0001.htm>
>
> ------------------------------
>
> Message: 3
> Date: Wed, 11 May 2011 16:53:09 -0500
> From: Emil Uzelac <emil at themeid.com>
> Subject: Re: [theme-reviewers] Cirumventing Theme Directory Preview in
>        Ticket #3787
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <BANLkTi=KZ_dL31v=5vd3TkYz=AgDpBo3oQ at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> That does not justify the redirect.
>
> *----*
> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
> emil at themeid.com | http://themeid.com
> Make everything as simple as possible, but not simpler. - Albert Einstein
>
>
>
> On Wed, May 11, 2011 at 4:51 PM, Jonny Cauvain <furcifer at furcifer.me> wrote:
>
>> The author of that theme is one of our reviewers.  XD and i see no problem
>> with that demo re-direct. But that's just my 2c
>>
>> On 11 May 2011 22:41, "Tony Jansen" <info at tonyjansen.nl> wrote:
>>
>>  Hello all,
>>
>>
>>
>> Earlier today during a review I encountered the following code in
>> functions.php:
>>
>> /**
>>
>> * The WordPress Theme Directory Preview may not be appropriate for this
>> theme, so redirecting to custom preview
>>
>>  */
>>
>> if( false !== strpos( site_url(), 'http://wp-themes.com'  )) {
>>
>>                 wp_redirect( 'http://demo.onedesigns.com/minimatica/' );
>>
>>                 exit();
>>
>> }
>>
>> which circumvents the regular theme preview to display something that may
>> have nothing to do with the theme at all or worse (not the case in this
>> case, mind you).
>>
>> I have halted the review after conferring with greuben, who noted that it
>> was bad and unacceptable, and I recommended a not-approved.
>>
>> This technique may be old hat but I still like to know what you think about
>> it, was I right to handle it this way?
>>
>>
>>
>> http://themes.trac.wordpress.org/ticket/3787#comment:3
>>
>>
>>
>> Best Regards,
>>
>> Tony Jansen
>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110511/e0d96def/attachment-0001.htm>
>
> ------------------------------
>
> Message: 4
> Date: Wed, 11 May 2011 22:54:40 +0100
> From: Jonny Cauvain <furcifer at furcifer.me>
> Subject: Re: [theme-reviewers] Cirumventing Theme Directory Preview in
>        Ticket #3787
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <BANLkTimb4EOyggnMQygAbN-0hvq4h6YNMA at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Of course it doesn't, but i see no problem with it, no matter who is doing
> it.
>
> On 11 May 2011 22:53, "Emil Uzelac" <emil at themeid.com> wrote:
>
> That does not justify the redirect.
>
> *----*
> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
> emil at themeid.com | http://themeid.com
> Make everything as simple as possible, but not simpler. - Albert Einstein
>
>
>
>
>
> On Wed, May 11, 2011 at 4:51 PM, Jonny Cauvain <furcifer at furcifer.me> wrote:
>>
>> The author of t...
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110511/17ea3a6f/attachment-0001.htm>
>
> ------------------------------
>
> Message: 5
> Date: Wed, 11 May 2011 16:59:59 -0500
> From: Emil Uzelac <emil at themeid.com>
> Subject: Re: [theme-reviewers] Cirumventing Theme Directory Preview in
>        Ticket #3787
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <BANLkTimtOv0B3gr+a493XOdwJHWa4vJ4nw at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Agreed if there is no written rule to it.
>
> *----*
> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
> emil at themeid.com | http://themeid.com
> Make everything as simple as possible, but not simpler. - Albert Einstein
>
>
>
> On Wed, May 11, 2011 at 4:54 PM, Jonny Cauvain <furcifer at furcifer.me> wrote:
>
>> Of course it doesn't, but i see no problem with it, no matter who is doing
>> it.
>>
>> On 11 May 2011 22:53, "Emil Uzelac" <emil at themeid.com> wrote:
>>
>> That does not justify the redirect.
>>
>> *----*
>> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
>> emil at themeid.com | http://themeid.com
>>  Make everything as simple as possible, but not simpler. - Albert Einstein
>>
>>
>>
>>
>>
>> On Wed, May 11, 2011 at 4:51 PM, Jonny Cauvain <furcifer at furcifer.me>
>> wrote:
>> >
>> > The author of t...
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110511/8919826d/attachment.htm>
>
> ------------------------------
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> End of theme-reviewers Digest, Vol 12, Issue 33
> ***********************************************
>

More information about the theme-reviewers mailing list