[theme-reviewers] Cirumventing Theme Directory Preview in Ticket #3787

[Emil Uzelac]

That does not justify the redirect.

*----*
*Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
emil at themeid.com | http://themeid.com
Make everything as simple as possible, but not simpler. - Albert Einstein



On Wed, May 11, 2011 at 4:51 PM, Jonny Cauvain <furcifer at furcifer.me> wrote:

> The author of that theme is one of our reviewers.  XD and i see no problem
> with that demo re-direct. But that's just my 2c
>
> On 11 May 2011 22:41, "Tony Jansen" <info at tonyjansen.nl> wrote:
>
>  Hello all,
>
>
>
> Earlier today during a review I encountered the following code in
> functions.php:
>
> /**
>
> * The WordPress Theme Directory Preview may not be appropriate for this
> theme, so redirecting to custom preview
>
>  */
>
> if( false !== strpos( site_url(), 'http://wp-themes.com'  )) {
>
>                 wp_redirect( 'http://demo.onedesigns.com/minimatica/' );
>
>                 exit();
>
> }
>
> which circumvents the regular theme preview to display something that may
> have nothing to do with the theme at all or worse (not the case in this
> case, mind you).
>
> I have halted the review after conferring with greuben, who noted that it
> was bad and unacceptable, and I recommended a not-approved.
>
> This technique may be old hat but I still like to know what you think about
> it, was I right to handle it this way?
>
>
>
> http://themes.trac.wordpress.org/ticket/3787#comment:3
>
>
>
> Best Regards,
>
> Tony Jansen
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110511/e0d96def/attachment.htm>